Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2839743002: Wires up WindowTreeClient::SetDisplayRoot() (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Wires up WindowTreeClient::SetDisplayRoot() Mush and mash will make use of this soon. BUG=708279 TEST=covered by test R=erg@chromium.org Review-Url: https://codereview.chromium.org/2839743002 Cr-Commit-Position: refs/heads/master@{#466781} Committed: https://chromium.googlesource.com/chromium/src/+/86bb8825f73b55690c94f3fca973462082715ae0

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : add .cc #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -9 lines) Patch
M ui/aura/mus/mus_types.h View 1 chunk +7 lines, -2 lines 0 comments Download
M ui/aura/mus/window_manager_delegate.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 3 chunks +7 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.cc View 6 chunks +65 lines, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus.h View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus_init_params.h View 2 chunks +25 lines, -0 lines 2 comments Download
M ui/aura/mus/window_tree_host_mus_init_params.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/test/mus/window_tree_client_private.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/test/mus/window_tree_client_private.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sky
3 years, 8 months ago (2017-04-24 20:43:12 UTC) #7
Elliot Glaysher
https://codereview.chromium.org/2839743002/diff/40001/ui/aura/mus/window_tree_host_mus_init_params.h File ui/aura/mus/window_tree_host_mus_init_params.h (right): https://codereview.chromium.org/2839743002/diff/40001/ui/aura/mus/window_tree_host_mus_init_params.h#newcode30 ui/aura/mus/window_tree_host_mus_init_params.h:30: struct AURA_EXPORT DisplayInitParams { Make this a moveable type ...
3 years, 8 months ago (2017-04-24 21:23:17 UTC) #8
sky
https://codereview.chromium.org/2839743002/diff/40001/ui/aura/mus/window_tree_host_mus_init_params.h File ui/aura/mus/window_tree_host_mus_init_params.h (right): https://codereview.chromium.org/2839743002/diff/40001/ui/aura/mus/window_tree_host_mus_init_params.h#newcode30 ui/aura/mus/window_tree_host_mus_init_params.h:30: struct AURA_EXPORT DisplayInitParams { On 2017/04/24 21:23:17, Elliot Glaysher ...
3 years, 8 months ago (2017-04-24 21:27:15 UTC) #9
Elliot Glaysher
fair enough. lgtm.
3 years, 8 months ago (2017-04-24 21:35:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839743002/40001
3 years, 8 months ago (2017-04-24 21:37:47 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 21:43:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/86bb8825f73b55690c94f3fca973...

Powered by Google App Engine
This is Rietveld 408576698