Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2839733005: [LayoutNG] Mark already-fixed vertical-align tests (Closed)

Created:
2 years, 4 months ago by kojii
Modified:
2 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Mark already-fixed vertical-align tests This patch marks tests that were fixed in the 'vertical-align' patch[1] but were missed and not updated in TestExpectations. [1] https://codereview.chromium.org/2803433002 BUG=636993 Review-Url: https://codereview.chromium.org/2839733005 Cr-Commit-Position: refs/heads/master@{#467273} Committed: https://chromium.googlesource.com/chromium/src/+/d1d30aceba74ab439f135cfcd88997870c030ebc

Patch Set 1 #

Patch Set 2 : Mark 1px diff for span/td as WontFix on Mac/Win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
kojii
PTAL.
2 years, 4 months ago (2017-04-26 06:42:26 UTC) #6
eae
LGTM!
2 years, 4 months ago (2017-04-26 06:50:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839733005/20001
2 years, 4 months ago (2017-04-26 08:52:29 UTC) #14
commit-bot: I haz the power
2 years, 4 months ago (2017-04-26 08:56:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d1d30aceba74ab439f135cfcd889...

Powered by Google App Engine
This is Rietveld 408576698