Disable offline pages tests on iOS

Disable offline pages tests on iOS

Since we won't be able to run on iOS without major work (we require
blink), I'm disabling our unit tests there for now.  They can be easily
re-enabled by reverting this change.

BUG=663311
Review-Url: https://codereview.chromium.org/2839723002
Cr-Commit-Position: refs/heads/master@{#467019}
Committed: https://chromium.googlesource.com/chromium/src/+/a1d20c2c1eaf66e21152653b62c285fcebd2f6f9

[Pete Williamson, 2017-04-24 18:41:31]

petewil@chromium.org changed reviewers:
+ fgorski@chromium.org, romax@chromium.org

[Pete Williamson, 2017-04-24 18:41:37]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 18:42:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[romax, 2017-04-24 18:53:36]

lgtm

[commit-bot: I haz the power, 2017-04-24 20:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 20:06:02]

Dry run: This issue passed the CQ dry run.

[fgorski, 2017-04-24 20:58:12]

lgtm.

I am Ok with disabling tests.
did you check that it is only iOS and Mac that suffer from the issue, and we
don't have a similar flakiness problem on Android?

[Pete Williamson, 2017-04-24 23:45:29]

On 2017/04/24 20:58:12, fgorski wrote:
> lgtm.
> 
> I am Ok with disabling tests.
> did you check that it is only iOS and Mac that suffer from the issue, and we
> don't have a similar flakiness problem on Android?

I checked the flakiness dashboard, we do not have a similar problem on Android.

[Pete Williamson, 2017-04-24 23:45:34]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:46:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 23:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:54:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Pete Williamson, 2017-04-25 00:04:02]

petewil@chromium.org changed reviewers:
+ blundell@chromium.org

[Pete Williamson, 2017-04-25 00:04:02]

+blundell for components/BUILD.gn

Since our component does not run on iOS (Android only), we are moving the unit
tests to the !iOS section to avoid causing any flakiness for iOS.

[blundell, 2017-04-25 14:23:04]

lgtm

Based on the CL description, it seems like we could also move the component away
from being a layered component?

[Pete Williamson, 2017-04-25 16:51:50]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2017-04-25 16:52:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 16:55:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493139110499350, "parent_rev":
"59b24c1b73e0548788d9b12969380e058f9ad770", "commit_rev":
"a1d20c2c1eaf66e21152653b62c285fcebd2f6f9"}

[commit-bot: I haz the power, 2017-04-25 16:55:54]

Description was changed from

==========
Disable offline pages tests on iOS

Since we won't be able to run on iOS without major work (we require
blink), I'm disabling our unit tests there for now.  They can be easily
re-enabled by reverting this change.

BUG=663311
==========

to

==========
Disable offline pages tests on iOS

Since we won't be able to run on iOS without major work (we require
blink), I'm disabling our unit tests there for now.  They can be easily
re-enabled by reverting this change.

BUG=663311

Review-Url: https://codereview.chromium.org/2839723002
Cr-Commit-Position: refs/heads/master@{#467019}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1d20c2c1eaf66e21152653b62c2...
==========

[commit-bot: I haz the power, 2017-04-25 16:55:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1d20c2c1eaf66e21152653b62c2...