Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: chrome/browser/ui/find_bar/find_bar_controller.h

Issue 2839713002: Fix extraneous beeps on empty page search. (Closed)
Patch Set: Un-reverse the conditional I broke last patch. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/find_bar/find_bar_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_controller.h
diff --git a/chrome/browser/ui/find_bar/find_bar_controller.h b/chrome/browser/ui/find_bar/find_bar_controller.h
index 89d252aed9d2a0eb9b3807b84039da469f2cdfb5..25ecaed12f3ee6d8969e63d9710f57861b2a8085 100644
--- a/chrome/browser/ui/find_bar/find_bar_controller.h
+++ b/chrome/browser/ui/find_bar/find_bar_controller.h
@@ -99,6 +99,12 @@ class FindBarController : public content::NotificationObserver {
// UpdateFindBarForCurrentResult to avoid flickering.
int last_reported_matchcount_;
+ // Used to keep track of whether the user has been notified that the find came
+ // up empty. A single find session can result in multiple final updates, if
+ // the document contents change dynamically. It's a nuisance to notify the
+ // user more than once that a search came up empty, however.
+ base::string16 alerted_search_;
+
DISALLOW_COPY_AND_ASSIGN(FindBarController);
};
« no previous file with comments | « no previous file | chrome/browser/ui/find_bar/find_bar_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698