Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: chrome/browser/ui/find_bar/find_bar_controller.h

Issue 2839713002: Fix extraneous beeps on empty page search. (Closed)
Patch Set: Un-reverse the conditional I broke last patch. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/find_bar/find_bar_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_FIND_BAR_FIND_BAR_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_FIND_BAR_FIND_BAR_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_FIND_BAR_FIND_BAR_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_FIND_BAR_FIND_BAR_CONTROLLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 92
93 std::unique_ptr<FindBar> find_bar_; 93 std::unique_ptr<FindBar> find_bar_;
94 94
95 // The WebContents we are currently associated with. Can be NULL. 95 // The WebContents we are currently associated with. Can be NULL.
96 content::WebContents* web_contents_; 96 content::WebContents* web_contents_;
97 97
98 // The last match count we reported to the user. This is used by 98 // The last match count we reported to the user. This is used by
99 // UpdateFindBarForCurrentResult to avoid flickering. 99 // UpdateFindBarForCurrentResult to avoid flickering.
100 int last_reported_matchcount_; 100 int last_reported_matchcount_;
101 101
102 // Used to keep track of whether the user has been notified that the find came
103 // up empty. A single find session can result in multiple final updates, if
104 // the document contents change dynamically. It's a nuisance to notify the
105 // user more than once that a search came up empty, however.
106 base::string16 alerted_search_;
107
102 DISALLOW_COPY_AND_ASSIGN(FindBarController); 108 DISALLOW_COPY_AND_ASSIGN(FindBarController);
103 }; 109 };
104 110
105 #endif // CHROME_BROWSER_UI_FIND_BAR_FIND_BAR_CONTROLLER_H_ 111 #endif // CHROME_BROWSER_UI_FIND_BAR_FIND_BAR_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/find_bar/find_bar_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698