Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: extensions/common/api/networking_private.idl

Issue 2839693003: MD Settings: Fix networking config errors (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/networking_private.idl
diff --git a/extensions/common/api/networking_private.idl b/extensions/common/api/networking_private.idl
index 5b9d9bd5f1fb8e1ba699a0d6c843f7fad02356da..176cb2eacc30a1e98a4f79b85cf320d684b08694 100644
--- a/extensions/common/api/networking_private.idl
+++ b/extensions/common/api/networking_private.idl
@@ -233,9 +233,12 @@ namespace networkingPrivate {
DOMString? ClientCertType;
DOMString? Identity;
DOMString? Inner;
- DOMString Outer;
+ // Outer is required by ONC, but may not be provided when translating
+ // fron Shill. TODO(stevenjb): Fix that in ShillToONCTranslator.
Devlin 2017/04/25 16:58:50 Typo: fron -> from Note: These become public docu
stevenjb 2017/04/25 18:05:15 Thanks for pointing that out. The TODO isn't reall
+ DOMString? Outer;
Devlin 2017/04/25 16:58:50 Does networking_onc.idl need to be updated?
stevenjb 2017/04/25 18:05:15 Kind of. It's actually missing the Managed version
DOMString? Password;
boolean? SaveCredentials;
+ DOMString[]? ServerCAPEMs;
DOMString[]? ServerCARefs;
boolean? UseProactiveKeyCaching;
boolean? UseSystemCAs;
@@ -248,9 +251,12 @@ namespace networkingPrivate {
ManagedDOMString? ClientCertType;
ManagedDOMString? Identity;
ManagedDOMString? Inner;
- ManagedDOMString Outer;
+ // Outer is required by ONC, but may not be provided when translating
+ // fron Shill. TODO(stevenjb): Fix that in ShillToONCTranslator.
+ ManagedDOMString? Outer;
ManagedDOMString? Password;
ManagedBoolean? SaveCredentials;
+ ManagedDOMStringList? ServerCAPEMs;
ManagedDOMStringList? ServerCARefs;
ManagedBoolean? UseProactiveKeyCaching;
ManagedBoolean? UseSystemCAs;

Powered by Google App Engine
This is Rietveld 408576698