Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2839693002: Add new UMA stats for parallelizable download (Closed)

Created:
3 years, 8 months ago by qinmin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, David Trainor- moved to gerrit, darin-cc_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Add new UMA stats for parallelizable download To study the effectiveness of parallel download, we want to compare the bandwidth if parallel downloads are not parallelized. Because parallel download has requirements on file size, so comparing with all other downloads is be fair. This CL records the UMA metrics for downloads that satisfy the requirement of parallel download, while don't use parallel requests. BUG=644352, 712892 TBR=dtrainor@chromium.org,alexmos@chromium.org,isherman@chromium.org Review-Url: https://codereview.chromium.org/2823273004 Cr-Commit-Position: refs/heads/master@{#466128} (cherry picked from commit 2269e30d4ea0874704bfbd4021c087ba960e7ea5) Review-Url: https://codereview.chromium.org/2839693002 . Cr-Commit-Position: refs/branch-heads/3071@{#168} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f7823c3140937e3fbfdc8eee48dfd780707b78e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -100 lines) Patch
M content/browser/download/download_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/download/download_file.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/download/download_file_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_file_impl.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_item_impl.cc View 7 chunks +21 lines, -12 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/download/download_job.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/download/download_job.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/download/download_job_factory.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M content/browser/download/download_job_impl.h View 2 chunks +6 lines, -1 line 0 comments Download
M content/browser/download/download_job_impl.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M content/browser/download/download_stats.h View 3 chunks +11 lines, -7 lines 0 comments Download
M content/browser/download/download_stats.cc View 8 chunks +52 lines, -24 lines 0 comments Download
M content/browser/download/mock_download_file.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/download/mock_download_file.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/download/parallel_download_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/parallel_download_job.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/download/parallel_download_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/download/parallel_download_utils.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/public/test/test_file_error_injector.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
3 years, 8 months ago (2017-04-24 17:44:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f7823c3140937e3fbfdc8eee48dfd780707b78e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698