Server-Timing

Server-Timing

Parse Server-Timing response headers and make the metric name(s), value(s), and
description(s) available as PerformanceServerTiming entries on the global
performance timeline and to PerformanceObservers. This feature is behind the
"ServerTiming" experimental-features flag.

To test, turn the flag on
(chrome://flags/#enable-experimental-web-platform-features) and explore to
https://server-timing.now.sh/. Execute `performance.getEntriesByType('server')`
in DevTools to inspect the 4 entries for the base page, as per the response
header:
server-timing:db=100; "Database metric", api=200; "HTTP/API metric", cache=300; "cache metric", total=0.000297322; "Total Response Time"

To inspect the 4 entries for the favicon.ico, you will need to set up a
PerformanceObserver (I use TamperMonkey to inject a content script) like this:
new PerformanceObserver(function(list, observer) {
  console.info(list.getEntries())
  observer.disconnect()
}).observe({entryTypes: ['server']})

Spec: https://w3c.github.io/server-timing/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/y3qwr490Fc4/boGoo41-BwAJ

BUG=702760
Review-Url: https://codereview.chromium.org/2839683003
Cr-Commit-Position: refs/heads/master@{#469303}
Committed: https://chromium.googlesource.com/chromium/src/+/9c4bf486b60e7913eff8100ca33dc0505ef421d9

[cvazac-akam, 2017-04-25 17:10:35]

Description was changed from

==========
Server-Timing

Parse Server-Timing response headers and make the metric name(s), value(s), and
description(s) available as PerformanceServerTiming entries on the global
performance timeline and to PerformanceObservers. This feature is behind the
"ServerTiming" experimental-features flag.

To test, turn the flag on
(chrome://flags/#enable-experimental-web-platform-features) and explore to
https://server-timing.now.sh/. Execute `performance.getEntriesByType('server')`
in DevTools to inspect the 4 entries for the base page, as per the response
header:
server-timing:db=100; "Database metric", api=200; "HTTP/API metric", cache=300;
"cache metric", total=0.000297322; "Total Response Time"

To inspect the 4 entries for the favicon.ico, you will need to set up a
PerformanceObserver (I use TamperMonkey to inject a content script) like this:
new PerformanceObserver(function(list, observer) {
  console.info(list.getEntries())
  observer.disconnect()
}).observe({entryTypes: ['server']})

Spec: https://w3c.github.io/server-timing/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/y3qwr490Fc4/bo...

BUG=702760
==========

to

==========
Server-Timing

Parse Server-Timing response headers and make the metric name(s), value(s), and
description(s) available as PerformanceServerTiming entries on the global
performance timeline and to PerformanceObservers. This feature is behind the
"ServerTiming" experimental-features flag.

To test, turn the flag on
(chrome://flags/#enable-experimental-web-platform-features) and explore to
https://server-timing.now.sh/. Execute `performance.getEntriesByType('server')`
in DevTools to inspect the 4 entries for the base page, as per the response
header:
server-timing:db=100; "Database metric", api=200; "HTTP/API metric", cache=300;
"cache metric", total=0.000297322; "Total Response Time"

To inspect the 4 entries for the favicon.ico, you will need to set up a
PerformanceObserver (I use TamperMonkey to inject a content script) like this:
new PerformanceObserver(function(list, observer) {
  console.info(list.getEntries())
  observer.disconnect()
}).observe({entryTypes: ['server']})

Spec: https://w3c.github.io/server-timing/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/y3qwr490Fc4/bo...

BUG=702760
==========

[cvazac-akam, 2017-04-25 17:10:35]

cvazac@akamai.com changed reviewers:
+ csharrison@chromium.org, panicker@chromium.org, yoav@yoav.ws

[cvazac-akam, 2017-05-01 16:04:53]

This is a re-upload of the triple-LGTM-ed case:
https://codereview.chromium.org/2799093004/

I had to re-upload from my @akamai.com address because that covers me on the
license agreement.

[panicker, 2017-05-01 20:52:08]

lgtm

[panicker, 2017-05-01 20:52:14]

The CQ bit was checked by panicker@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 20:52:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 20:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 20:58:07]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yoav Weiss, 2017-05-02 09:37:47]

On 2017/05/01 20:52:08, panicker wrote:
> lgtm

LGTM2!

[Yoav Weiss, 2017-05-02 09:37:54]

The CQ bit was checked by yoav@yoav.ws

[Yoav Weiss, 2017-05-02 09:37:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2839683003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-02 09:38:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 09:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 09:48:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mike West, 2017-05-02 12:11:58]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2017-05-02 12:11:58]

RS LGTM based on the other patch.

[Yoav Weiss, 2017-05-02 12:16:22]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2017-05-02 12:16:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 13:40:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 13:40:05]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cvazac-akam, 2017-05-02 21:09:30]

The CQ bit was checked by cvazac@akamai.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 21:09:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 23:52:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 23:52:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yoav Weiss, 2017-05-03 08:20:04]

https://codereview.chromium.org/2839683003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/network/HTTPParsers.cpp (right):

https://codereview.chromium.org/2839683003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/network/HTTPParsers.cpp:900: if (*position ==
'=') {
Seems like your ASAN issues are originating here. I suspect that when skipWhile
finds no delimiter (e.g. "blablabla" as an input string), ParseServerTimingToken
will return a `position` equivalent to `end`. `end` is beyond the defined
buffer, so reading from it is a buffer overflow. You should add protections that
break out of the loop when `end` is reached in the middle of it.

[Yoav Weiss, 2017-05-03 19:53:57]

The CQ bit was checked by yoav@yoav.ws

[Yoav Weiss, 2017-05-03 19:53:57]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2839683003/#ps80001
(title: "make those robots happy, attempt #3")

[commit-bot: I haz the power, 2017-05-03 19:54:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-05-04 07:40:35]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 07:40:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 10:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 10:06:09]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2017-05-04 10:08:10]

The CQ bit was checked by yoav@yoav.ws

[Yoav Weiss, 2017-05-04 10:08:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2839683003/#ps100001
(title: "make those robots happy, attempt #4")

[commit-bot: I haz the power, 2017-05-04 10:08:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 10:14:50]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493892490063230,
"parent_rev": "05864d5cb320715302b6d39f88728ff0a8776378", "commit_rev":
"9c4bf486b60e7913eff8100ca33dc0505ef421d9"}

[commit-bot: I haz the power, 2017-05-04 10:15:01]

Description was changed from

==========
Server-Timing

Parse Server-Timing response headers and make the metric name(s), value(s), and
description(s) available as PerformanceServerTiming entries on the global
performance timeline and to PerformanceObservers. This feature is behind the
"ServerTiming" experimental-features flag.

To test, turn the flag on
(chrome://flags/#enable-experimental-web-platform-features) and explore to
https://server-timing.now.sh/. Execute `performance.getEntriesByType('server')`
in DevTools to inspect the 4 entries for the base page, as per the response
header:
server-timing:db=100; "Database metric", api=200; "HTTP/API metric", cache=300;
"cache metric", total=0.000297322; "Total Response Time"

To inspect the 4 entries for the favicon.ico, you will need to set up a
PerformanceObserver (I use TamperMonkey to inject a content script) like this:
new PerformanceObserver(function(list, observer) {
  console.info(list.getEntries())
  observer.disconnect()
}).observe({entryTypes: ['server']})

Spec: https://w3c.github.io/server-timing/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/y3qwr490Fc4/bo...

BUG=702760
==========

to

==========
Server-Timing

Parse Server-Timing response headers and make the metric name(s), value(s), and
description(s) available as PerformanceServerTiming entries on the global
performance timeline and to PerformanceObservers. This feature is behind the
"ServerTiming" experimental-features flag.

To test, turn the flag on
(chrome://flags/#enable-experimental-web-platform-features) and explore to
https://server-timing.now.sh/. Execute `performance.getEntriesByType('server')`
in DevTools to inspect the 4 entries for the base page, as per the response
header:
server-timing:db=100; "Database metric", api=200; "HTTP/API metric", cache=300;
"cache metric", total=0.000297322; "Total Response Time"

To inspect the 4 entries for the favicon.ico, you will need to set up a
PerformanceObserver (I use TamperMonkey to inject a content script) like this:
new PerformanceObserver(function(list, observer) {
  console.info(list.getEntries())
  observer.disconnect()
}).observe({entryTypes: ['server']})

Spec: https://w3c.github.io/server-timing/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/y3qwr490Fc4/bo...

BUG=702760

Review-Url: https://codereview.chromium.org/2839683003
Cr-Commit-Position: refs/heads/master@{#469303}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c4bf486b60e7913eff8100ca33d...
==========

[commit-bot: I haz the power, 2017-05-04 10:15:02]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9c4bf486b60e7913eff8100ca33d...

[Nico, 2017-05-12 01:42:24]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-05-12 01:42:25]

Please update the member variable names:

https://codereview.chromium.org/2839683003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/timing/PerformanceServerTiming.h (right):

https://codereview.chromium.org/2839683003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/timing/PerformanceServerTiming.h:37: const String
m_metric;
This file uses old blink style. Please name member variables foo_bar_ instead of
m_fooBar. Methods that aren't exposesd in idl should be called Method() instead
of method().