Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2839633002: Introduce ComputeTextBounds template in Range.cpp (Closed)

Created:
3 years, 8 months ago by tanvir
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ComputeTextBounds template in Range.cpp Currently textQuads and ComputeTextRects algorithm is mostly same. The difference of behaviour of these two functions can be handled efficiently by using templates. This CL is the Second patch set to achieve the above behaviour. This CL introduces ComputeTextBounds as template function, which will be used by computeTextRects only in this patch. BUG=691198 Review-Url: https://codereview.chromium.org/2839633002 Cr-Commit-Position: refs/heads/master@{#467707} Committed: https://chromium.googlesource.com/chromium/src/+/deb0172c664a689bff370a530764f975480443f5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated PS #

Total comments: 4

Patch Set 3 : AddressedReviewComments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/Range.cpp View 1 2 2 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
tanvir
PS#2. PTAL. Thanks!!!
3 years, 8 months ago (2017-04-25 06:10:20 UTC) #3
yosin_UTC9
Code changes are good. Please wait patch[1] for using |const LayoutText&| for |CollectAbsoluteBoundsForRange()|. [1] http://crrev.com/2837273002: ...
3 years, 8 months ago (2017-04-25 06:54:34 UTC) #8
tanvir
PTAL!!! Thanks https://codereview.chromium.org/2839633002/diff/1/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2839633002/diff/1/third_party/WebKit/Source/core/dom/Range.cpp#newcode1446 third_party/WebKit/Source/core/dom/Range.cpp:1446: LayoutText* layout_text) { On 2017/04/25 06:54:34, yosin_UTC9 ...
3 years, 8 months ago (2017-04-26 09:36:30 UTC) #9
yosin_UTC9
lgtm +tkent@ for OWNERS review.
3 years, 8 months ago (2017-04-27 06:35:01 UTC) #15
tkent
https://codereview.chromium.org/2839633002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2839633002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp#newcode1443 third_party/WebKit/Source/core/dom/Range.cpp:1443: static void CollectAbsoluteBoundsForRange(Vector<IntRect>& rects, Please make |rects| the last ...
3 years, 8 months ago (2017-04-27 06:40:37 UTC) #16
tanvir
Addressed Review Comments. PTAL https://codereview.chromium.org/2839633002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2839633002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp#newcode1443 third_party/WebKit/Source/core/dom/Range.cpp:1443: static void CollectAbsoluteBoundsForRange(Vector<IntRect>& rects, On ...
3 years, 7 months ago (2017-04-27 14:26:29 UTC) #17
tkent
lgtm
3 years, 7 months ago (2017-04-27 14:43:18 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839633002/40001
3 years, 7 months ago (2017-04-27 14:43:42 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 16:40:14 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/deb0172c664a689bff370a530764...

Powered by Google App Engine
This is Rietveld 408576698