Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2839623002: Make //content/public/renderer dependency on //media public (Closed)

Created:
3 years, 8 months ago by Tomasz Moniuszko
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make //content/public/renderer dependency on //media public There's following include chain: content/public/renderer/content_renderer_client.h media/base/decode_capabilities.h media/base/video_color_space.h ui/gfx/color_space.h third_party/skia/include/core/SkColorSpace.h SkMatrix44.h Dependency chain must be also public to make sure that target that depends on //content/public/renderer has include paths configured properly and skia header inclusion doesn't cause 'include file not found' error during compilation. BUG= Review-Url: https://codereview.chromium.org/2839623002 Cr-Commit-Position: refs/heads/master@{#467018} Committed: https://chromium.googlesource.com/chromium/src/+/59b24c1b73e0548788d9b12969380e058f9ad770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/public/renderer/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Tomasz Moniuszko
3 years, 8 months ago (2017-04-24 14:06:32 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-25 15:04:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839623002/1
3 years, 8 months ago (2017-04-25 15:33:36 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 16:48:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/59b24c1b73e0548788d9b1296938...

Powered by Google App Engine
This is Rietveld 408576698