Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2839573002: Merge of "Add attempt count metric to FaviconHandler" into M59. (Closed)

Created:
3 years, 8 months ago by vitaliii
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge of "Add attempt count metric to FaviconHandler" into M59. This is a merge of https://codereview.chromium.org/2781093002 into M59 (3071). Done on behalf of fhorschig@. Reason: recording metrics in M59 (and not waiting for M60). === Original description === The histograms this metric introduces aggregates how many download attempts were needed to determine the best-fitting favicon. This is stored in two metrics in order to separate requests for large icons. BUG=672939 Review-Url: https://codereview.chromium.org/2781093002 Cr-Commit-Position: refs/heads/master@{#465526} (cherry picked from commit a9fb2c3cf6bc9b4877d9c21f9f12094fb5c26ecd) Review-Url: https://codereview.chromium.org/2839573002 . Cr-Commit-Position: refs/branch-heads/3071@{#157} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/29f35e1cdef86ccb133616795b0845130d2cad86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -11 lines) Patch
M components/favicon/core/favicon_handler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/favicon/core/favicon_handler.cc View 9 chunks +35 lines, -0 lines 0 comments Download
M components/favicon/core/favicon_handler_unittest.cc View 6 chunks +128 lines, -11 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vitaliii
3 years, 8 months ago (2017-04-24 08:23:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29f35e1cdef86ccb133616795b0845130d2cad86.

Powered by Google App Engine
This is Rietveld 408576698