Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2839553002:
Add headless resources to Windows platform, now that's enabled (Closed)
|
Created:
3 years, 8 months ago by dvallet Modified:
3 years, 7 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd headless resources to Windows platform, now that's enabled
This patch adds headless resources (1.7 Kb) to all those versions
Launch bug: http://crbug.com/705916
BUG=686608
Review-Url: https://codereview.chromium.org/2839553002
Cr-Commit-Position: refs/heads/master@{#472022}
Committed: https://chromium.googlesource.com/chromium/src/+/7bbfe9f60233e5bed915af951a960210c9c94cc2
Patch Set 1 #Patch Set 2 : moved dependencies to non android builds #Messages
Total messages: 24 (16 generated)
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dvallet@chromium.org changed reviewers: + jochen@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
lgtm
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494910762681600,
"parent_rev": "981a96bc5df9e0c392193199c5a6d701a973f0f0", "commit_rev":
"7bbfe9f60233e5bed915af951a960210c9c94cc2"}
Message was sent while issue was closed.
Description was changed from ========== Add headless resources to Windows platform, now that's enabled This patch adds headless resources (1.7 Kb) to all those versions Launch bug: http://crbug.com/705916 BUG=686608 ========== to ========== Add headless resources to Windows platform, now that's enabled This patch adds headless resources (1.7 Kb) to all those versions Launch bug: http://crbug.com/705916 BUG=686608 Review-Url: https://codereview.chromium.org/2839553002 Cr-Commit-Position: refs/heads/master@{#472022} Committed: https://chromium.googlesource.com/chromium/src/+/7bbfe9f60233e5bed915af951a96... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7bbfe9f60233e5bed915af951a96... |
