Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2839533004:
Use TaskScheduler instead of blocking pool in shell_url_request_context_getter.cc. (Closed)
DescriptionUse TaskScheduler instead of blocking pool in shell_url_request_context_getter.cc.
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=peter@chromium.org
Review-Url: https://codereview.chromium.org/2839533004
Cr-Commit-Position: refs/heads/master@{#467393}
Committed: https://chromium.googlesource.com/chromium/src/+/66a4f03d888d59aa66337e3e150ac205a207e1e1
Patch Set 1 #
Total comments: 2
Patch Set 2 : user-visible #Messages
Total messages: 18 (11 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority())? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior())? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
peter@chromium.org changed reviewers: + bauerb@chromium.org
+bauerb FYI https://codereview.chromium.org/2839533004/diff/1/content/shell/browser/shell... File content/shell/browser/shell_url_request_context_getter.cc (right): https://codereview.chromium.org/2839533004/diff/1/content/shell/browser/shell... content/shell/browser/shell_url_request_context_getter.cc:263: .WithPriority(base::TaskPriority::BACKGROUND) The protocol handlers for file:// and content:// (Android-only) in //chrome are also registered with BACKGROUND priority, but that seems odd for something that will be considered for navigation? USER_VISIBLE seems more appropriate. https://chromium.googlesource.com/chromium/src/+/bd0ab22004781d47c24045d1ac8d... https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_io_data.... bauerb@ (who reviewed the other CL) agrees, so would you mind updating that here any in //chrome/browser/profiles/profile_io_data.cc?
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAnL https://codereview.chromium.org/2839533004/diff/1/content/shell/browser/shell... File content/shell/browser/shell_url_request_context_getter.cc (right): https://codereview.chromium.org/2839533004/diff/1/content/shell/browser/shell... content/shell/browser/shell_url_request_context_getter.cc:263: .WithPriority(base::TaskPriority::BACKGROUND) On 2017/04/26 14:30:37, Peter Beverloo wrote: > The protocol handlers for file:// and content:// (Android-only) in //chrome are > also registered with BACKGROUND priority, but that seems odd for something that > will be considered for navigation? USER_VISIBLE seems more appropriate. > > https://chromium.googlesource.com/chromium/src/+/bd0ab22004781d47c24045d1ac8d... > > https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_io_data.... > > bauerb@ (who reviewed the other CL) agrees, so would you mind updating that here > any in //chrome/browser/profiles/profile_io_data.cc? Done. https://codereview.chromium.org/2845683002/
lgtm
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493229769292270,
"parent_rev": "58a9ac7a9f534ef3cda229da75cff9e6f6487a24", "commit_rev":
"66a4f03d888d59aa66337e3e150ac205a207e1e1"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in shell_url_request_context_getter.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=peter@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in shell_url_request_context_getter.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=peter@chromium.org Review-Url: https://codereview.chromium.org/2839533004 Cr-Commit-Position: refs/heads/master@{#467393} Committed: https://chromium.googlesource.com/chromium/src/+/66a4f03d888d59aa66337e3e150a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/66a4f03d888d59aa66337e3e150a... |
