components/translate/core/browser/translate_ranker_impl.cc - Issue 2839433002: [translate] Fix shutdown race for translate ranker model loader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2839433002: [translate] Fix shutdown race for translate ranker model loader. (Closed)

Patch Set: fdoray part deux Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/browser/translate_ranker_impl.cc

diff --git a/components/translate/core/browser/translate_ranker_impl.cc b/components/translate/core/browser/translate_ranker_impl.cc

index 906c498f964e219b6a57fecbed801ee529d65ae7..1c84e8461c8a012879413aa0eb2e5cfc5d3f9112 100644

--- a/components/translate/core/browser/translate_ranker_impl.cc

+++ b/components/translate/core/browser/translate_ranker_impl.cc

@@ -156,7 +156,8 @@ TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path,

base::Bind(&TranslateRankerImpl::OnModelAvailable,

weak_ptr_factory_.GetWeakPtr()),

model_path, model_url, kUmaPrefix);

- model_loader_->Start();

+ // Kick off the initial load from cache.

+ model_loader_->NotifyOfRankerActivity();

}