Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: components/translate/core/browser/translate_download_manager.cc

Issue 2839433002: [translate] Fix shutdown race for translate ranker model loader. (Closed)
Patch Set: fdoray part deux Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_download_manager.cc
diff --git a/components/translate/core/browser/translate_download_manager.cc b/components/translate/core/browser/translate_download_manager.cc
index 88c01777409bc1943e92387aa82a75b895c43b2d..1687fa1b326a678ee4a0bf307f22c9a97b37d4cb 100644
--- a/components/translate/core/browser/translate_download_manager.cc
+++ b/components/translate/core/browser/translate_download_manager.cc
@@ -24,6 +24,7 @@ TranslateDownloadManager::TranslateDownloadManager()
TranslateDownloadManager::~TranslateDownloadManager() {}
void TranslateDownloadManager::Shutdown() {
+ DCHECK(sequence_checker_.CalledOnValidSequence());
language_list_.reset();
script_.reset();
request_context_ = NULL;
@@ -99,11 +100,13 @@ void TranslateDownloadManager::ClearTranslateScriptForTesting() {
}
void TranslateDownloadManager::ResetForTesting() {
+ DCHECK(sequence_checker_.CalledOnValidSequence());
language_list_.reset(new TranslateLanguageList);
script_.reset(new TranslateScript);
}
void TranslateDownloadManager::SetTranslateScriptExpirationDelay(int delay_ms) {
+ DCHECK(sequence_checker_.CalledOnValidSequence());
if (script_.get() == NULL) {
NOTREACHED();
return;

Powered by Google App Engine
This is Rietveld 408576698