Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2839423002:
[recipes.py] move common arg parsing to separate module. (Closed)
|
Created:
3 years, 7 months ago by iannucci Modified:
3 years, 7 months ago CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org Target Ref:
refs/heads/master Project:
recipe_engine Visibility:
Public. |
Description[recipes.py] move common arg parsing to separate module.
This will allow easier testing in upcoming patchsets.
R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2839423002
Committed: https://github.com/luci/recipes-py/commit/73d1232b112d420c35023b2c8536f7f473cc61d0
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : rebase #Patch Set 5 : rebase #Patch Set 6 : move argparse below env #Patch Set 7 : put back missing arg #Messages
Total messages: 33 (29 generated)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35c61924b12f8510)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35c67b72e0407310)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #5 (id:80001) has been deleted
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35d3a27f9835d210)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by iannucci@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org Link to the patchset: https://codereview.chromium.org/2839423002/#ps140001 (title: "put back missing arg")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493488486277540,
"parent_rev": "088cc7b5423bcf53a6545ac3483ed2a891ae723f", "commit_rev":
"73d1232b112d420c35023b2c8536f7f473cc61d0"}
Message was sent while issue was closed.
Description was changed from ========== [recipes.py] move common arg parsing to separate module. This will allow easier testing in upcoming patchsets. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= ========== to ========== [recipes.py] move common arg parsing to separate module. This will allow easier testing in upcoming patchsets. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/2839423002 Committed: https://github.com/luci/recipes-py/commit/73d1232b112d420c35023b2c8536f7f473c... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:140001) as https://github.com/luci/recipes-py/commit/73d1232b112d420c35023b2c8536f7f473c... |
