Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2839413004: MD Settings: Tweak omnibox search engine look to match other search engines. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Tweak omnibox search engine look to match other search engines. BUG=715466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2839413004 Cr-Commit-Position: refs/heads/master@{#468160} Committed: https://chromium.googlesource.com/chromium/src/+/52cb55108113396c95ba08d9e40c0ba18f528de3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dpapad
Screenshots: http://imgur.com/a/EsKDA Before: no padding, different line wrapping than "other search engines" After: Same padding ...
3 years, 7 months ago (2017-04-28 00:50:54 UTC) #3
dschuyler
lgtm
3 years, 7 months ago (2017-04-28 19:21:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839413004/1
3 years, 7 months ago (2017-04-28 22:33:12 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 22:38:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52cb55108113396c95ba08d9e40c...

Powered by Google App Engine
This is Rietveld 408576698