Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2839413003: Delete Cronet Data Reduction Proxy integration (Closed)

Created:
3 years, 7 months ago by mgersh
Modified:
3 years, 7 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, net-reviews_chromium.org, agrieve+watch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete Cronet Data Reduction Proxy integration No one is using it, so we've decided to delete the code. The removals from api.txt are safe because that code is known to be unused, partly because it wouldn't have worked anyway. BUG=716108 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2839413003 Cr-Commit-Position: refs/heads/master@{#468029} Committed: https://chromium.googlesource.com/chromium/src/+/f95d508c15009e62252c38701982042740289d84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -666 lines) Patch
M components/cronet/android/BUILD.gn View 6 chunks +0 lines, -27 lines 0 comments Download
M components/cronet/android/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/android/api.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java View 1 chunk +0 lines, -31 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java View 2 chunks +0 lines, -5 lines 0 comments Download
D components/cronet/android/cronet_data_reduction_proxy.h View 1 chunk +0 lines, -86 lines 0 comments Download
D components/cronet/android/cronet_data_reduction_proxy.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D components/cronet/android/cronet_in_memory_pref_store.h View 1 chunk +0 lines, -69 lines 0 comments Download
D components/cronet/android/cronet_in_memory_pref_store.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.h View 2 chunks +0 lines, -8 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 5 chunks +0 lines, -37 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java View 2 chunks +0 lines, -39 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java View 2 chunks +3 lines, -7 lines 0 comments Download
D components/cronet/android/test/assets/test/datareductionproxysuccess.txt View 1 chunk +0 lines, -1 line 0 comments Download
D components/cronet/android/test/assets/test/datareductionproxysuccess.txt.mock-http-headers View 1 chunk +0 lines, -5 lines 0 comments Download
M components/cronet/android/test/cronet_url_request_context_config_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 2 chunks +0 lines, -45 lines 0 comments Download
M components/cronet/android/test/native_test_server.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/NativeTestServer.java View 2 chunks +0 lines, -5 lines 0 comments Download
M components/cronet/ios/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/cronet/stale_host_resolver_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/cronet/url_request_context_config.h View 3 chunks +0 lines, -18 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 3 chunks +1 line, -12 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
mgersh
PTAL. I'll wait to land this until after https://codereview.chromium.org/2845093005/ lands.
3 years, 7 months ago (2017-04-27 17:58:01 UTC) #3
mef
lgtm. Could you create crbug for this and add BUG= to this CL?
3 years, 7 months ago (2017-04-27 18:09:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839413003/1
3 years, 7 months ago (2017-04-28 14:12:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/359422)
3 years, 7 months ago (2017-04-28 15:36:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839413003/1
3 years, 7 months ago (2017-04-28 15:57:02 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 16:59:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f95d508c15009e62252c38701982...

Powered by Google App Engine
This is Rietveld 408576698