Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2839403005: check if webcontents are available at tabs_api (Closed)

Created:
3 years, 7 months ago by Ilya Tskhay
Modified:
3 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

check if webcontents are available at tabs_api Everywhere else access to webcontents via tab_strip->GetWebContentsAt(i) is checked. Missing check here may lead to crash in rare cases. R=benwells@chromium.org BUG= Review-Url: https://codereview.chromium.org/2839403005 Cr-Commit-Position: refs/heads/master@{#468577} Committed: https://chromium.googlesource.com/chromium/src/+/3bab4c6795d212364941d58d6c46af4783622fbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ilya Tskhay
3 years, 7 months ago (2017-04-28 09:55:23 UTC) #1
benwells
lgtm
3 years, 7 months ago (2017-05-01 23:04:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839403005/1
3 years, 7 months ago (2017-05-02 06:33:30 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 07:16:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3bab4c6795d212364941d58d6c46...

Powered by Google App Engine
This is Rietveld 408576698