Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2839393002: MD Bookmarks: Update TestStore API (Closed)

Created:
6 months, 3 weeks ago by tsergeant
Modified:
6 months, 3 weeks ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Update TestStore API This changes TestStore to inherit from Store, allowing tests to use more production code paths. It also adds a new flag to TestStore which allows page actions to be handled normally (rather than preventing them from executing), which is useful for integration testing. BUG=697706 Review-Url: https://codereview.chromium.org/2839393002 Cr-Commit-Position: refs/heads/master@{#467607} Committed: https://chromium.googlesource.com/chromium/src/+/5cdc120ce13ae37a6019159936d54920556f9b54

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bye, curlies #

Messages

Total messages: 14 (9 generated)
tsergeant
6 months, 3 weeks ago (2017-04-27 01:45:18 UTC) #2
calamity
lgtm https://codereview.chromium.org/2839393002/diff/1/chrome/test/data/webui/md_bookmarks/test_store.js File chrome/test/data/webui/md_bookmarks/test_store.js (right): https://codereview.chromium.org/2839393002/diff/1/chrome/test/data/webui/md_bookmarks/test_store.js#newcode23 chrome/test/data/webui/md_bookmarks/test_store.js:23: } nit: no curlies.
6 months, 3 weeks ago (2017-04-27 04:23:53 UTC) #7
tsergeant
https://codereview.chromium.org/2839393002/diff/1/chrome/test/data/webui/md_bookmarks/test_store.js File chrome/test/data/webui/md_bookmarks/test_store.js (right): https://codereview.chromium.org/2839393002/diff/1/chrome/test/data/webui/md_bookmarks/test_store.js#newcode23 chrome/test/data/webui/md_bookmarks/test_store.js:23: } On 2017/04/27 04:23:53, calamity wrote: > nit: no ...
6 months, 3 weeks ago (2017-04-27 04:48:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839393002/20001
6 months, 3 weeks ago (2017-04-27 04:48:47 UTC) #11
commit-bot: I haz the power
6 months, 3 weeks ago (2017-04-27 06:40:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5cdc120ce13ae37a6019159936d5...

Powered by Google App Engine
This is Rietveld efc10ee0f