Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: extensions/common/extension.h

Issue 2839373003: struct UnloadedExtensionInfo -> enum UnloadedExtensionInfoReason (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension.h
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index b87cc5f2dd89f1c6962631c25306fdb08d0dee98..da4a192ade18850aa306c26427577404cb3c343a 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -514,27 +514,18 @@ struct InstalledExtensionInfo {
const std::string& old_name);
};
-struct UnloadedExtensionInfo {
- // TODO(DHNishi): Move this enum to ExtensionRegistryObserver.
- enum Reason {
- REASON_UNDEFINED, // Undefined state used to initialize variables.
- REASON_DISABLE, // Extension is being disabled.
- REASON_UPDATE, // Extension is being updated to a newer version.
- REASON_UNINSTALL, // Extension is being uninstalled.
- REASON_TERMINATE, // Extension has terminated.
- REASON_BLACKLIST, // Extension has been blacklisted.
- REASON_PROFILE_SHUTDOWN, // Profile is being shut down.
- REASON_LOCK_ALL, // All extensions for the profile are blocked.
- REASON_MIGRATED_TO_COMPONENT, // Extension is being migrated to a component
- // action.
- };
-
- Reason reason;
-
- // The extension being unloaded - this should always be non-NULL.
- const Extension* extension;
-
- UnloadedExtensionInfo(const Extension* extension, Reason reason);
+// TODO(DHNishi): Move this enum to ExtensionRegistryObserver.
+enum UnloadedExtensionReason {
Devlin 2017/05/01 14:08:57 We should make this an enum class; otherwise the v
limasdf 2017/05/02 07:52:52 Yeah, we should. (sorry I didn't catch that) I'll
+ REASON_UNDEFINED, // Undefined state used to initialize variables.
+ REASON_DISABLE, // Extension is being disabled.
+ REASON_UPDATE, // Extension is being updated to a newer version.
+ REASON_UNINSTALL, // Extension is being uninstalled.
+ REASON_TERMINATE, // Extension has terminated.
+ REASON_BLACKLIST, // Extension has been blacklisted.
+ REASON_PROFILE_SHUTDOWN, // Profile is being shut down.
+ REASON_LOCK_ALL, // All extensions for the profile are blocked.
+ REASON_MIGRATED_TO_COMPONENT, // Extension is being migrated to a component
+ // action.
};
// The details sent for EXTENSION_PERMISSIONS_UPDATED notifications.

Powered by Google App Engine
This is Rietveld 408576698