struct UnloadedExtensionInfo -> enum UnloadedExtensionInfoReason

extensions/common/extension.h

Index: extensions/common/extension.h
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index b87cc5f2dd89f1c6962631c25306fdb08d0dee98..da4a192ade18850aa306c26427577404cb3c343a 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -514,27 +514,18 @@ struct InstalledExtensionInfo {
                          const std::string& old_name);
 };
 
-struct UnloadedExtensionInfo {
-  // TODO(DHNishi): Move this enum to ExtensionRegistryObserver.
-  enum Reason {
-    REASON_UNDEFINED,         // Undefined state used to initialize variables.
-    REASON_DISABLE,           // Extension is being disabled.
-    REASON_UPDATE,            // Extension is being updated to a newer version.
-    REASON_UNINSTALL,         // Extension is being uninstalled.
-    REASON_TERMINATE,         // Extension has terminated.
-    REASON_BLACKLIST,         // Extension has been blacklisted.
-    REASON_PROFILE_SHUTDOWN,  // Profile is being shut down.
-    REASON_LOCK_ALL,          // All extensions for the profile are blocked.
-    REASON_MIGRATED_TO_COMPONENT,  // Extension is being migrated to a component
-                                   // action.
-  };
-
-  Reason reason;
-
-  // The extension being unloaded - this should always be non-NULL.
-  const Extension* extension;
-
-  UnloadedExtensionInfo(const Extension* extension, Reason reason);
+// TODO(DHNishi): Move this enum to ExtensionRegistryObserver.
+enum UnloadedExtensionReason {

[Devlin, 2017/05/01 14:08:57]

We should make this an enum class; otherwise the values are defined at the scope
of the extensions namespace (e.g., extensions::REASON_UNDEFINED would work -
which is a little too vague).

Two options:
1) Just make this an enum class in this file; everything should still work with
no other changes (because you've specified all the enums with the more targeted
scoping already in the code).
2) Make this an enum class and remove the REASON_ prefix from the values.  This
would be a *bit* cleaner, because UnloadedExtensionReason::REASON_FOO is a
little redundant compared to UnloadedExtensionReason::FOO.  If you have a
find-replace script that works well, this shouldn't be too hard
(s/UnloadedExtensionReason::REASON_/UnloadedExtensionReason::), but if there's
any trouble, then don't worry about it - it's a very small detail. :)

[limasdf, 2017/05/02 07:52:52]

Yeah, we should. (sorry I didn't catch that)
I'll take option#2 to remove duplicated word, 'reason'.

+  REASON_UNDEFINED,         // Undefined state used to initialize variables.
+  REASON_DISABLE,           // Extension is being disabled.
+  REASON_UPDATE,            // Extension is being updated to a newer version.
+  REASON_UNINSTALL,         // Extension is being uninstalled.
+  REASON_TERMINATE,         // Extension has terminated.
+  REASON_BLACKLIST,         // Extension has been blacklisted.
+  REASON_PROFILE_SHUTDOWN,  // Profile is being shut down.
+  REASON_LOCK_ALL,          // All extensions for the profile are blocked.
+  REASON_MIGRATED_TO_COMPONENT,  // Extension is being migrated to a component
+                                 // action.
 };
 
 // The details sent for EXTENSION_PERMISSIONS_UPDATED notifications.