struct UnloadedExtensionInfo -> enum UnloadedExtensionInfoReason

extensions/common/extension.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_EXTENSION_H_
 #define EXTENSIONS_COMMON_EXTENSION_H_
 
 #include <map>
 #include <memory>
 #include <set>
@@ skipping 496 matching lines @@
   // The name of the extension prior to this update. Will be empty if
   // |is_update| is false.
   std::string old_name;
 
   InstalledExtensionInfo(const Extension* extension,
                          bool is_update,
                          bool from_ephemeral,
                          const std::string& old_name);
 };
 
-struct UnloadedExtensionInfo {
-  // TODO(DHNishi): Move this enum to ExtensionRegistryObserver.
-  enum Reason {
-    REASON_UNDEFINED,         // Undefined state used to initialize variables.
-    REASON_DISABLE,           // Extension is being disabled.
-    REASON_UPDATE,            // Extension is being updated to a newer version.
-    REASON_UNINSTALL,         // Extension is being uninstalled.
-    REASON_TERMINATE,         // Extension has terminated.
-    REASON_BLACKLIST,         // Extension has been blacklisted.
-    REASON_PROFILE_SHUTDOWN,  // Profile is being shut down.
-    REASON_LOCK_ALL,          // All extensions for the profile are blocked.
-    REASON_MIGRATED_TO_COMPONENT,  // Extension is being migrated to a component
-                                   // action.
-  };
-
-  Reason reason;
-
-  // The extension being unloaded - this should always be non-NULL.
-  const Extension* extension;
-
-  UnloadedExtensionInfo(const Extension* extension, Reason reason);
+// TODO(DHNishi): Move this enum to ExtensionRegistryObserver.
+enum UnloadedExtensionReason {

[Devlin, 2017/05/01 14:08:57]

We should make this an enum class; otherwise the values are defined at the scope
of the extensions namespace (e.g., extensions::REASON_UNDEFINED would work -
which is a little too vague).

Two options:
1) Just make this an enum class in this file; everything should still work with
no other changes (because you've specified all the enums with the more targeted
scoping already in the code).
2) Make this an enum class and remove the REASON_ prefix from the values.  This
would be a *bit* cleaner, because UnloadedExtensionReason::REASON_FOO is a
little redundant compared to UnloadedExtensionReason::FOO.  If you have a
find-replace script that works well, this shouldn't be too hard
(s/UnloadedExtensionReason::REASON_/UnloadedExtensionReason::), but if there's
any trouble, then don't worry about it - it's a very small detail. :)

[limasdf, 2017/05/02 07:52:52]

Yeah, we should. (sorry I didn't catch that)
I'll take option#2 to remove duplicated word, 'reason'.

+  REASON_UNDEFINED,         // Undefined state used to initialize variables.
+  REASON_DISABLE,           // Extension is being disabled.
+  REASON_UPDATE,            // Extension is being updated to a newer version.
+  REASON_UNINSTALL,         // Extension is being uninstalled.
+  REASON_TERMINATE,         // Extension has terminated.
+  REASON_BLACKLIST,         // Extension has been blacklisted.
+  REASON_PROFILE_SHUTDOWN,  // Profile is being shut down.
+  REASON_LOCK_ALL,          // All extensions for the profile are blocked.
+  REASON_MIGRATED_TO_COMPONENT,  // Extension is being migrated to a component
+                                 // action.
 };
 
 // The details sent for EXTENSION_PERMISSIONS_UPDATED notifications.
 struct UpdatedExtensionPermissionsInfo {
   enum Reason {
     ADDED,    // The permissions were added to the extension.
     REMOVED,  // The permissions were removed from the extension.
     POLICY,   // The policy that affects permissions was updated.
   };
 
   Reason reason;
 
   // The extension who's permissions have changed.
   const Extension* extension;
 
   // The permissions that have changed. For Reason::ADDED, this would contain
   // only the permissions that have added, and for Reason::REMOVED, this would
   // only contain the removed permissions.
   const PermissionSet& permissions;
 
   UpdatedExtensionPermissionsInfo(const Extension* extension,
                                   const PermissionSet& permissions,
                                   Reason reason);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_EXTENSION_H_