Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2839373002: Implement SPDY_EXPORT and SPDY_EXPORT_PRIVATE macros. (Closed)

Created:
6 months, 3 weeks ago by Bence
Modified:
6 months, 3 weeks ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, fuzzing_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement SPDY_EXPORT and SPDY_EXPORT_PRIVATE macros. Also change all occurrences of SPDY_EXPORT into SPDY_EXPORT_PRIVATE. This is to be used in shared code (net/spdy/core). Note that SPDY_EXPORT is not used at all, just like QUIC_EXPORT (defined in net/quic/platform) is not used either. Review-Url: https://codereview.chromium.org/2839373002 Cr-Commit-Position: refs/heads/master@{#467745} Committed: https://chromium.googlesource.com/chromium/src/+/c4c12fd03602a3ab702b75cbe804df9c13e95188

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re: #7. #

Patch Set 3 : Rebase: manually resolve trivial merge conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -108 lines) Patch
M net/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/core/fuzzing/hpack_fuzz_util.h View 3 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/core/hpack/hpack_constants.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/core/hpack/hpack_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/core/hpack/hpack_decoder3.h View 4 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/core/hpack/hpack_decoder_interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/core/hpack/hpack_encoder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/core/hpack/hpack_entry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/core/hpack/hpack_header_table.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/core/hpack/hpack_huffman_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/core/hpack/hpack_huffman_table.h View 4 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/core/hpack/hpack_input_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/core/hpack/hpack_output_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/core/hpack/hpack_static_table.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/core/spdy_alt_svc_wire_format.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/core/spdy_frame_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/core/spdy_frame_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/core/spdy_framer.h View 8 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/core/spdy_header_block.h View 6 chunks +10 lines, -10 lines 0 comments Download
M net/spdy/core/spdy_header_indexing.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/core/spdy_headers_handler_interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/core/spdy_pinnable_buffer_piece.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/core/spdy_prefixed_buffer_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/core/spdy_protocol.h View 1 2 22 chunks +35 lines, -34 lines 0 comments Download
M net/spdy/core/write_scheduler.h View 2 chunks +2 lines, -2 lines 0 comments Download
A net/spdy/platform/api/spdy_export.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
A net/spdy/platform/impl/spdy_export_impl.h View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Bence
xunjieli: PTAL. Thank you.
6 months, 3 weeks ago (2017-04-27 09:55:08 UTC) #6
xunjieli
lgtm https://codereview.chromium.org/2839373002/diff/1/net/spdy/platform/impl/spdy_export_impl.h File net/spdy/platform/impl/spdy_export_impl.h (right): https://codereview.chromium.org/2839373002/diff/1/net/spdy/platform/impl/spdy_export_impl.h#newcode1 net/spdy/platform/impl/spdy_export_impl.h:1: // Copyright 2016 The Chromium Authors. All rights ...
6 months, 3 weeks ago (2017-04-27 12:12:48 UTC) #7
Bence
Thank you. https://codereview.chromium.org/2839373002/diff/1/net/spdy/platform/impl/spdy_export_impl.h File net/spdy/platform/impl/spdy_export_impl.h (right): https://codereview.chromium.org/2839373002/diff/1/net/spdy/platform/impl/spdy_export_impl.h#newcode1 net/spdy/platform/impl/spdy_export_impl.h:1: // Copyright 2016 The Chromium Authors. All ...
6 months, 3 weeks ago (2017-04-27 12:16:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839373002/20001
6 months, 3 weeks ago (2017-04-27 12:16:25 UTC) #11
commit-bot: I haz the power
Failed to apply patch for net/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
6 months, 3 weeks ago (2017-04-27 14:08:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839373002/40001
6 months, 3 weeks ago (2017-04-27 15:11:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/414271)
6 months, 3 weeks ago (2017-04-27 16:38:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839373002/40001
6 months, 3 weeks ago (2017-04-27 17:59:46 UTC) #20
commit-bot: I haz the power
6 months, 3 weeks ago (2017-04-27 19:12:04 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c4c12fd03602a3ab702b75cbe804...

Powered by Google App Engine
This is Rietveld efc10ee0f