Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2839303002: Revert of Disable WebRtcCaptureFromElementBrowserTest.VerifyCanvasWebGLCaptureColor on android (Closed)

Created:
3 years, 7 months ago by braveyao
Modified:
3 years, 7 months ago
Reviewers:
emircan, mcasas, mattcary
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disabling flaky WebRtcCaptureFromElementBrowserTest.VerifyCanvasWebGLCaptureColor on android (patchset #1 id:1 of https://codereview.chromium.org/2835973002/ ) Reason for revert: Can't reproduce this locally with ToT. Guess it may be affected by issue715069 or other bots failures. Let's reenable it and check. Original issue's description: > Disabling flaky WebRtcCaptureFromElementBrowserTest.VerifyCanvasWebGLCaptureColor on android > > emircan and mcasas to TBR as taken from recent changes to the same tests. > > BUG=714549 > TBR=emircan@chromium.org,mcasas@chromium.org > > Review-Url: https://codereview.chromium.org/2835973002 > Cr-Commit-Position: refs/heads/master@{#466608} > Committed: https://chromium.googlesource.com/chromium/src/+/5983d0ae0dc74c59f63c1851637ae2a8a13421d6 TBR=emircan@chromium.org,mcasas@chromium.org,mattcary@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=714549 Review-Url: https://codereview.chromium.org/2839303002 Cr-Commit-Position: refs/heads/master@{#467517} Committed: https://chromium.googlesource.com/chromium/src/+/362999207c6a8a108bdbf2d4ea7400e6ad0b2554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M content/browser/webrtc/webrtc_capture_from_element_browsertest.cc View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
braveyao
Created Revert of Disabling flaky WebRtcCaptureFromElementBrowserTest.VerifyCanvasWebGLCaptureColor on android
3 years, 7 months ago (2017-04-26 21:51:19 UTC) #2
emircan
lgtm
3 years, 7 months ago (2017-04-26 22:27:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839303002/1
3 years, 7 months ago (2017-04-26 22:28:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/362999207c6a8a108bdbf2d4ea7400e6ad0b2554
3 years, 7 months ago (2017-04-26 23:47:16 UTC) #13
mattcary
3 years, 7 months ago (2017-04-27 07:51:27 UTC) #14
Message was sent while issue was closed.
lgtm

sgtm, thanks for looking into the issue.

Powered by Google App Engine
This is Rietveld 408576698