Named arg completion fixes (flutter-intellij#551)

pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
index 67baee0e442c60d3810f5bb65ac9890fc305dad6..775cc389e4e0898d3399de136930ec342ce13ebf 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -118,6 +118,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
       bool isPotential: false,
       String elemFile,
       int elemOffset,
+      int selectionOffset,
       String paramName,
       String paramType,
       String defaultArgListString: _UNCHECKED,
@@ -134,7 +135,9 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
       expect(cs.relevance, equals(relevance), reason: completion);
     }
     expect(cs.importUri, importUri);
-    expect(cs.selectionOffset, equals(completion.length));
+    if (selectionOffset != null) {

[danrubel, 2017/04/27 14:04:14]

This change will prevent cs.selectionOffset from being checked in 99% of the
cases where it was previously checked. I recommend replacing these three lines
with

expect(cs.selectionOffset, equals(selectionOffset ?? completion.length));

[pquitslund, 2017/04/27 17:09:54]

I need to pick this up in a follow-up CL.  Net-net: we don't want to default to
completion.length for cases where a comma is included and we'll need to update a
bunch of tests.

+      expect(cs.selectionOffset, equals(selectionOffset));
+    }
     expect(cs.selectionLength, equals(0));
     expect(cs.isDeprecated, equals(isDeprecated));
     expect(cs.isPotential, equals(isPotential));