Named arg completion fixes (flutter-intellij#551)

pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.dart.util;
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/protocol/protocol.dart' as protocol
     show Element, ElementKind;
@@ skipping 100 matching lines @@
 
   CompletionSuggestion assertSuggest(String completion,
       {CompletionSuggestionKind csKind: CompletionSuggestionKind.INVOCATION,
       int relevance: DART_RELEVANCE_DEFAULT,
       String importUri,
       protocol.ElementKind elemKind: null,
       bool isDeprecated: false,
       bool isPotential: false,
       String elemFile,
       int elemOffset,
+      int selectionOffset,
       String paramName,
       String paramType,
       String defaultArgListString: _UNCHECKED,
       List<int> defaultArgumentListTextRanges}) {
     CompletionSuggestion cs =
         getSuggest(completion: completion, csKind: csKind, elemKind: elemKind);
     if (cs == null) {
       failedCompletion('expected $completion $csKind $elemKind', suggestions);
     }
     expect(cs.kind, equals(csKind));
     if (isDeprecated) {
       expect(cs.relevance, equals(DART_RELEVANCE_LOW));
     } else {
       expect(cs.relevance, equals(relevance), reason: completion);
     }
     expect(cs.importUri, importUri);
-    expect(cs.selectionOffset, equals(completion.length));
+    if (selectionOffset != null) {

[danrubel, 2017/04/27 14:04:14]

This change will prevent cs.selectionOffset from being checked in 99% of the
cases where it was previously checked. I recommend replacing these three lines
with

expect(cs.selectionOffset, equals(selectionOffset ?? completion.length));

[pquitslund, 2017/04/27 17:09:54]

I need to pick this up in a follow-up CL.  Net-net: we don't want to default to
completion.length for cases where a comma is included and we'll need to update a
bunch of tests.

+      expect(cs.selectionOffset, equals(selectionOffset));
+    }
     expect(cs.selectionLength, equals(0));
     expect(cs.isDeprecated, equals(isDeprecated));
     expect(cs.isPotential, equals(isPotential));
     if (cs.element != null) {
       expect(cs.element.location, isNotNull);
       expect(cs.element.location.file, isNotNull);
       expect(cs.element.location.offset, isNotNull);
       expect(cs.element.location.length, isNotNull);
       expect(cs.element.location.startColumn, isNotNull);
       expect(cs.element.location.startLine, isNotNull);
@@ skipping 487 matching lines @@
 
   @override
   void setUp() {
     super.setUp();
     index = createMemoryIndex();
     searchEngine =
         new SearchEngineImpl(index, (_) => new AstProviderForContext(context));
     contributor = createContributor();
   }
 }