third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html - Issue 2839263002: Don't promote position: fixed elements with composited descendants if they don't scroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html

Issue 2839263002: Don't promote position: fixed elements with composited descendants if they don't scroll (Closed)

Patch Set: Address reviewer comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite-expected.txt ('k') | third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite-expected.txt » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html

diff --git a/third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite.html b/third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html

similarity index 79%

rename from third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite.html

rename to third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html

index a972d50bdf8e6100bca9d800eb74823d801c4ce9..412c8766e963a014d63942b42f5c6f71f454d7f3 100644

--- a/third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite.html

+++ b/third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html

@@ -1,10 +1,11 @@

<!doctype HTML>

Any errors will show below this line.

-

+

</div>

+<div style="height: 2000px;"></div>

if (window.testRunner)