third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html - Issue 2839263002: Don't promote position: fixed elements with composited descendants if they don't scroll

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html

Issue 2839263002: Don't promote position: fixed elements with composited descendants if they don't scroll (Closed)

Patch Set: Address reviewer comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype HTML>	1 <!doctype HTML>

2 Any errors will show below this line.	2 Any errors will show below this line.

3 <!-- Having a composited child should always be a position:fixed compositing tri gger -->	3 <!-- Having a composited child should be a position:fixed compositing trigger wh en scrollable -->

4 <div style="position: fixed; width: 100px; height: 100px; background: lightgray" >	4 <div style="position: fixed; width: 100px; height: 100px; background: lightgray" >

5 <div style="will-change: transform; margin: 50px; width: 50px; height: 50px; background: lightblue">	5 <div style="will-change: transform; margin: 50px; width: 50px; height: 50px; background: lightblue">

6 </div>	6 </div>

7 </div>	7 </div>

	8 <div style="height: 2000px;"></div>

8 <script src="../resources/testharness.js"></script>	9 <script src="../resources/testharness.js"></script>

9 <script>	10 <script>

10 if (window.testRunner)	11 if (window.testRunner)

11 testRunner.dumpAsText();	12 testRunner.dumpAsText();

12 if (window.internals) {	13 if (window.internals) {

13 var layers = JSON.parse(internals.layerTreeAsText(document));	14 var layers = JSON.parse(internals.layerTreeAsText(document));

14 assert_true(layers["layers"].length == 3);	15 assert_true(layers["layers"].length == 3);

15 }	16 }

16 </script>	17 </script>

OLD	NEW