IME for Mus: Structs and StructTraits for IME Candidate Window.

IME for Mus: Structs and StructTraits for IME Candidate Window.

This CL adds ui.mojom.CandidateWindowProperties and
ui.mojom.CandidateWindowEntry and corresponding struct traits.

BUG=637416, 672587
Review-Url: https://codereview.chromium.org/2839243002
Cr-Commit-Position: refs/heads/master@{#467686}
Committed: https://chromium.googlesource.com/chromium/src/+/b69ccf6f92a78f8dc097466d8132b7ccfd000950

[Hadi, 2017-04-26 18:08:34]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:09:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-04-26 18:09:58]

Description was changed from

==========
IME for Mus: Structs and StructTraits for IME Candidate Window.

BUG=637416, 637416
==========

to

==========
IME for Mus: Structs and StructTraits for IME Candidate Window.

This CL adds ui.mojom.CandidateWindowProperties and
ui.mojom.CandidateWindowEntry and corresponding struct traits.

BUG=637416, 637416
==========

[Hadi, 2017-04-26 18:12:48]

moshayedi@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Hadi, 2017-04-26 18:12:48]

PTAL.

In subsequent CLs I am planning to add the mojo API for interacting with
candidate windows.

[Tom Sepez, 2017-04-26 18:41:13]

mojom LGTM

[Hadi, 2017-04-26 19:09:57]

Description was changed from

==========
IME for Mus: Structs and StructTraits for IME Candidate Window.

This CL adds ui.mojom.CandidateWindowProperties and
ui.mojom.CandidateWindowEntry and corresponding struct traits.

BUG=637416, 637416
==========

to

==========
IME for Mus: Structs and StructTraits for IME Candidate Window.

This CL adds ui.mojom.CandidateWindowProperties and
ui.mojom.CandidateWindowEntry and corresponding struct traits.

BUG=637416, 672587
==========

[commit-bot: I haz the power, 2017-04-26 19:41:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 19:41:09]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-26 20:03:23]

https://codereview.chromium.org/2839243002/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/ime/ime.mojom (right):

https://codereview.chromium.org/2839243002/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/ime/ime.mojom:15: CURSOR,
The *new* style for enums is kFoo.

https://codereview.chromium.org/2839243002/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/ime/ime_struct_traits_test.mojom (right):

https://codereview.chromium.org/2839243002/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/ime/ime_struct_traits_test.mojom:11:
EchoCandidateWindowProperties(CandidateWindowProperties in)
You shouldn't need a mojom to test serialization. See
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-mojo/trait...
.

[Hadi, 2017-04-27 12:34:20]

https://codereview.chromium.org/2839243002/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/ime/ime.mojom (right):

https://codereview.chromium.org/2839243002/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/ime/ime.mojom:15: CURSOR,
On 2017/04/26 20:03:23, sky wrote:
> The *new* style for enums is kFoo.

Done.

https://codereview.chromium.org/2839243002/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/ime/ime_struct_traits_test.mojom (right):

https://codereview.chromium.org/2839243002/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/ime/ime_struct_traits_test.mojom:11:
EchoCandidateWindowProperties(CandidateWindowProperties in)
On 2017/04/26 20:03:23, sky wrote:
> You shouldn't need a mojom to test serialization. See
>
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-mojo/trait...
> .

Done.

[Hadi, 2017-04-27 12:35:46]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 12:36:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-04-27 13:14:42]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 13:15:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-04-27 13:21:46]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 13:22:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 14:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 14:19:33]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-27 15:23:09]

LGTM

[Hadi, 2017-04-27 15:25:07]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2017-04-27 15:25:08]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2839243002/#ps60001
(title: "Check for deserialization success.")

[commit-bot: I haz the power, 2017-04-27 15:25:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 15:31:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493306707732120,
"parent_rev": "560458ed6c19491dc39cb5a6f5317cc0a9d705df", "commit_rev":
"b69ccf6f92a78f8dc097466d8132b7ccfd000950"}

[commit-bot: I haz the power, 2017-04-27 15:31:35]

Description was changed from

==========
IME for Mus: Structs and StructTraits for IME Candidate Window.

This CL adds ui.mojom.CandidateWindowProperties and
ui.mojom.CandidateWindowEntry and corresponding struct traits.

BUG=637416, 672587
==========

to

==========
IME for Mus: Structs and StructTraits for IME Candidate Window.

This CL adds ui.mojom.CandidateWindowProperties and
ui.mojom.CandidateWindowEntry and corresponding struct traits.

BUG=637416, 672587

Review-Url: https://codereview.chromium.org/2839243002
Cr-Commit-Position: refs/heads/master@{#467686}
Committed:
https://chromium.googlesource.com/chromium/src/+/b69ccf6f92a78f8dc097466d8132...
==========

[commit-bot: I haz the power, 2017-04-27 15:31:37]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b69ccf6f92a78f8dc097466d8132...