Issue 2839223003: Use sourceElement when eliminating Phis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2839223003: Use sourceElement when eliminating Phis (Closed)

Created:
3 years, 8 months ago by sra1

Modified:
3 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use sourceElement when eliminating Phis The generated code is more readable since it has more names from the original program. In a very small number of cases the number of locals increases. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/391feb15ca133d89fdc286d774e8047927934412

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	pkg/compiler/lib/src/ssa/nodes.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	pkg/compiler/lib/src/ssa/optimize.dart	View	1	3 chunks	+12 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

3 years, 8 months ago (2017-04-27 00:21:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
391feb15ca133d89fdc286d774e8047927934412 (presubmit successful).