Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: base/win/object_watcher.h

Issue 2839213002: [Synchronization] Fix a crash in WaitableEventWatcher (Closed)
Patch Set: Fix grammar in comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/synchronization/waitable_event_watcher_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/object_watcher.h
diff --git a/base/win/object_watcher.h b/base/win/object_watcher.h
index 67a1e26c76cd1665b700f896075777d4c66abe58..6fddc588dec715c0c17981ae6037697bb08fcc0a 100644
--- a/base/win/object_watcher.h
+++ b/base/win/object_watcher.h
@@ -26,6 +26,10 @@ namespace win {
// UnregisterWaitEx is automatically called, and any in-flight notification is
// suppressed.
//
+// The waiting handle MUST NOT be closed while watching is in progress. If this
+// handle is closed while the wait is still pending, the behavior is undefined
+// (see MSDN:RegisterWaitForSingleObject).
+//
// Typical usage:
//
// class MyClass : public base::win::ObjectWatcher::Delegate {
« no previous file with comments | « base/synchronization/waitable_event_watcher_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698