Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2839183002: Refactor scroll updates after layout. (Closed)

Created:
3 years, 8 months ago by szager1
Modified:
3 years, 7 months ago
Reviewers:
skobes
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, dshwang, Manuel Rego, fs, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, krit, zoltan1, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, rwlbuis, jfernandez, atotic+reviews_chromium.org, eae+blinkwatch, blink-reviews-layout_chromium.org, cbiesinger, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, svillar, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, fmalita+watch_chromium.org, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor scroll updates after layout. Every LayoutBox with a PaintLayer will do some layer updating at the end of its layout; this consists of: - updating the layer's transform - updating the layer's scrollable area, if necessary - in the near future, updating the layer's size This change consolidates all of those into LayoutBox::UpdateAfterLayout. BUG=701575 R=skobes@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2839183002 Cr-Commit-Position: refs/heads/master@{#467995} Committed: https://chromium.googlesource.com/chromium/src/+/61472254f109375173180671106927aa6867699a

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutIFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
szager1
This is part one of the set-layer-size-during-layout refactor.
3 years, 8 months ago (2017-04-26 16:53:09 UTC) #6
skobes
lgtm w/ nit: please expand the change description to be a little more specific.
3 years, 7 months ago (2017-04-27 23:16:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839183002/1
3 years, 7 months ago (2017-04-28 10:50:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/441225)
3 years, 7 months ago (2017-04-28 10:54:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839183002/20001
3 years, 7 months ago (2017-04-28 13:02:27 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 14:59:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/61472254f1093751731806711069...

Powered by Google App Engine
This is Rietveld 408576698