Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2839103002:
Do not convert mouse move events to mouse leave or enter events in blink (Closed)
DescriptionDo not convert mouse move events to mouse leave events in blink
In blink, we convert mouse enter and leave events to mouse move events,
we should not do it anymore. We should keep their types, so we know
they are actual enter or leave events.
I looked at the code, PointerEventManager::SendMousePointerEvent has a
separate argument called mouse_event_type, which is always the type of
mouse move, and mouseevent's type is not referred anymore. It should
be safe to remove the conversion.
BUG=686196
Review-Url: https://codereview.chromium.org/2839103002
Cr-Commit-Position: refs/heads/master@{#467674}
Committed: https://chromium.googlesource.com/chromium/src/+/b40772db092d28a4abfa3b0d869b0cb9815f3d1b
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== sent mouseleave BUG= ========== to ========== Do not convert mouse move events to mouse leave events in blink In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. BUG=686196 ==========
lanwei@chromium.org changed reviewers: + dtapuska@chromium.org
lanwei@chromium.org changed reviewers: + bokan@chromium.org
Description was changed from ========== Do not convert mouse move events to mouse leave events in blink In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. BUG=686196 ========== to ========== Do not convert mouse move events to mouse leave events in blink In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. I looked at the code, PointerEventManager::SendMousePointerEvent has a separate argument called mouse_event_type, which is always the type of mouse move, and they do not refer to mouseevent's type anymore. It should be safe to remove the conversion. BUG=686196 ==========
Description was changed from ========== Do not convert mouse move events to mouse leave events in blink In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. I looked at the code, PointerEventManager::SendMousePointerEvent has a separate argument called mouse_event_type, which is always the type of mouse move, and they do not refer to mouseevent's type anymore. It should be safe to remove the conversion. BUG=686196 ========== to ========== Do not convert mouse move events to mouse leave events in blink In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. I looked at the code, PointerEventManager::SendMousePointerEvent has a separate argument called mouse_event_type, which is always the type of mouse move, and mouseevent's type is not referred anymore. It should be safe to remove the conversion. BUG=686196 ==========
Hi Lan, Please wrap the commit message at 72 cols. Does this have any potential web impact? Could this cause a change to what events we fire at the page?
Description was changed from ========== Do not convert mouse move events to mouse leave events in blink In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. I looked at the code, PointerEventManager::SendMousePointerEvent has a separate argument called mouse_event_type, which is always the type of mouse move, and mouseevent's type is not referred anymore. It should be safe to remove the conversion. BUG=686196 ========== to ========== Do not convert mouse move events to mouse leave events in blink In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. I looked at the code, PointerEventManager::SendMousePointerEvent has a separate argument called mouse_event_type, which is always the type of mouse move, and mouseevent's type is not referred anymore. It should be safe to remove the conversion. BUG=686196 ==========
On 2017/04/26 21:03:50, bokan wrote: > Hi Lan, > > Please wrap the commit message at 72 cols. > > Does this have any potential web impact? Could this cause a change to what > events we fire at the page? No, blink will send the right events. In BoundaryEventDispatcher::SendBoundaryEvents, it will decide the right event types, such as mouseenter, mouseleave, mouseover and mouseout, by hittesting not mouseevent's type.
Ok then, lgtm :)
On 2017/04/26 21:22:46, bokan wrote: > Ok then, lgtm :) lgtm. Are we eventually going to push the mouseleave further into blink? ie. So the pointer event manager knows about it?
On 2017/04/26 21:30:17, dtapuska wrote: > On 2017/04/26 21:22:46, bokan wrote: > > Ok then, lgtm :) > > lgtm. Are we eventually going to push the mouseleave further into blink? ie. So > the pointer event manager knows about it? Yes, I have another patch that will remove pointer id for pointer events that have a mouse leave type, so we can set the future coming pointer events' isPrimary correctly. Please see https://codereview.chromium.org/2831933002/.
The CQ bit was checked by lanwei@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493298583435070, "parent_rev":
"730e3cee9100751b3fb33c40f58c68e246e483be", "commit_rev":
"b40772db092d28a4abfa3b0d869b0cb9815f3d1b"}
Message was sent while issue was closed.
Description was changed from ========== Do not convert mouse move events to mouse leave events in blink In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. I looked at the code, PointerEventManager::SendMousePointerEvent has a separate argument called mouse_event_type, which is always the type of mouse move, and mouseevent's type is not referred anymore. It should be safe to remove the conversion. BUG=686196 ========== to ========== Do not convert mouse move events to mouse leave events in blink In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. I looked at the code, PointerEventManager::SendMousePointerEvent has a separate argument called mouse_event_type, which is always the type of mouse move, and mouseevent's type is not referred anymore. It should be safe to remove the conversion. BUG=686196 Review-Url: https://codereview.chromium.org/2839103002 Cr-Commit-Position: refs/heads/master@{#467674} Committed: https://chromium.googlesource.com/chromium/src/+/b40772db092d28a4abfa3b0d869b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b40772db092d28a4abfa3b0d869b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
