Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2839073002: [Chromecast] Include internal JUnit tests on non-public builds. (Closed)

Created:
3 years, 8 months ago by Simeon
Modified:
3 years, 8 months ago
Reviewers:
slan, halliwell, mbjorge
CC:
alokp+watch_chromium.org, chromium-reviews, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Include internal JUnit tests on non-public builds. BUG=Internal b/22464493 TEST=build cast_junit_test_lists on internal build check output in out/debug/junit Review-Url: https://codereview.chromium.org/2839073002 Cr-Commit-Position: refs/heads/master@{#467213} Committed: https://chromium.googlesource.com/chromium/src/+/65702e4e611c06215736d9b0fd2d1839445a1f05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chromecast/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Simeon
We now have a couple of internal junit test suites that we should include in ...
3 years, 8 months ago (2017-04-26 01:00:39 UTC) #2
mbjorge
lgtm
3 years, 8 months ago (2017-04-26 01:02:16 UTC) #3
halliwell
On 2017/04/26 01:02:16, mbjorge wrote: > lgtm lgtm
3 years, 8 months ago (2017-04-26 01:17:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839073002/1
3 years, 8 months ago (2017-04-26 01:22:30 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 02:49:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65702e4e611c06215736d9b0fd2d...

Powered by Google App Engine
This is Rietveld 408576698