third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h - Issue 2839063003: Implement tail processing for AudioNodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

Issue 2839063003: Implement tail processing for AudioNodes (Closed)

Patch Set: Make declaration order consistent Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp ('k') | third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

index f4881789643d47b510da6efd58b78d2fc82fca13..bf5bb75f97cb7021b2dfc33b63b15462d0aea132 100644

--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

@@ -55,7 +55,6 @@ class MODULES_EXPORT DynamicsCompressorHandler final : public AudioHandler {

void Process(size_t frames_to_process) override;

void ProcessOnlyAudioParams(size_t frames_to_process) override;

void Initialize() override;

- void ClearInternalStateWhenDisabled() override;

float ReductionValue() const { return reduction_; }

@@ -67,6 +66,7 @@ class MODULES_EXPORT DynamicsCompressorHandler final : public AudioHandler {

AudioParamHandler& ratio,

AudioParamHandler& attack,

AudioParamHandler& release);

+ bool RequiresTailProcessing() const override;

double TailTime() const override;

double LatencyTime() const override;