third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp - Issue 2839063003: Implement tail processing for AudioNodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

Issue 2839063003: Implement tail processing for AudioNodes (Closed)

Patch Set: Make declaration order consistent Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h ('k') | third_party/WebKit/Source/modules/webaudio/GainNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

index 031b484242bf74d66362c1de9f8be60d7dca5110..6b1ae74b6de1dc8ce3b6ad462210881a9277a8a9 100644

--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

@@ -121,8 +121,10 @@ void DynamicsCompressorHandler::Initialize() {

Context()->sampleRate(), defaultNumberOfOutputChannels));

}

-void DynamicsCompressorHandler::ClearInternalStateWhenDisabled() {

- reduction_ = 0;

+bool DynamicsCompressorHandler::RequiresTailProcessing() const {

+ // Always return true even if the tail time and latency might both

+ // be zero.

+ return true;

}

double DynamicsCompressorHandler::TailTime() const {