third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h - Issue 2839063003: Implement tail processing for AudioNodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

Issue 2839063003: Implement tail processing for AudioNodes (Closed)

Patch Set: Make declaration order consistent Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

index 7c515bab9c6955002cc520601773a7ea2c886223..f3652f050c1317bab40ce0cf01f8d1631365db9f 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

@@ -81,6 +81,10 @@ class AudioScheduledSourceHandler : public AudioHandler {

bool HasFinished() const { return GetPlaybackState() == FINISHED_STATE; }

+ // Source nodes don't have tail or latency times so no tail

+ // processing needed.

+ bool RequiresTailProcessing() const override { return false; }

protected:

// Get frame information for the current time quantum.

// We handle the transition into PLAYING_STATE and FINISHED_STATE here,