Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2839053002: Image Capture: don't set PhotoCapabilities width/height if min/max are both zero (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
CC:
chromium-reviews, haraken, blink-reviews, mcasas+imagecapture_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: don't set PhotoCapabilities width/height if min/max are both zero This CL avoids setting PhotoCapabilities.{width,height} if the platform has min/max values of zero, respectively. BUG=715159 Review-Url: https://codereview.chromium.org/2839053002 Cr-Commit-Position: refs/heads/master@{#467364} Committed: https://chromium.googlesource.com/chromium/src/+/57934e7bb8f2c9c787b61ee7f3b41dbc11f1760d

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
mcasas
reillyg@ another tiny CL, ptal
3 years, 8 months ago (2017-04-26 16:04:19 UTC) #8
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-04-26 17:18:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839053002/20001
3 years, 8 months ago (2017-04-26 17:23:01 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 17:29:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/57934e7bb8f2c9c787b61ee7f3b4...

Powered by Google App Engine
This is Rietveld 408576698