Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: device/u2f/u2f_request.h

Issue 2839043002: Pass u2f message callback vector as a const reference (Closed)
Patch Set: Change response callback to const ref Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/u2f/u2f_register_unittest.cc ('k') | device/u2f/u2f_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/u2f/u2f_request.h
diff --git a/device/u2f/u2f_request.h b/device/u2f/u2f_request.h
index 902a2ca84d6f51275e2a93b97c9c37a6722dff72..f8d8f3ab8408131c3cdd28f9067ad2587e44b03a 100644
--- a/device/u2f/u2f_request.h
+++ b/device/u2f/u2f_request.h
@@ -14,8 +14,9 @@
namespace device {
class U2fRequest : HidService::Observer {
public:
- using ResponseCallback = base::Callback<void(U2fReturnCode status_code,
- std::vector<uint8_t> response)>;
+ using ResponseCallback =
+ base::Callback<void(U2fReturnCode status_code,
+ const std::vector<uint8_t>& response)>;
U2fRequest(const ResponseCallback& callback);
virtual ~U2fRequest();
« no previous file with comments | « device/u2f/u2f_register_unittest.cc ('k') | device/u2f/u2f_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698