Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

Issue 2839003002: Reorder parameters in Instrumentation.record(). (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
index a3f88f5b5e3a301bf4b8547f1c93de61459caeed..5781b2196f418c8d327ade21cf11bf05676a7aad 100644
--- a/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
@@ -147,7 +147,7 @@ abstract class TypeInferrerImpl<S, E, V, F> extends TypeInferrer<S, E, V, F> {
}
}
if (needToSetReturnType) {
- instrumentation?.record('returnType', Uri.parse(uri), offset,
+ instrumentation?.record(Uri.parse(uri), offset, 'returnType',
new InstrumentationValueForType(inferredReturnType));
setReturnType(inferredReturnType);
}
@@ -210,7 +210,7 @@ abstract class TypeInferrerImpl<S, E, V, F> extends TypeInferrer<S, E, V, F> {
var inferredType =
inferExpression(initializer, declaredType, declaredType == null);
if (strongMode && declaredType == null) {
- instrumentation?.record('type', Uri.parse(uri), offset,
+ instrumentation?.record(Uri.parse(uri), offset, 'type',
new InstrumentationValueForType(inferredType));
setType(inferredType);
}
@@ -228,9 +228,9 @@ abstract class TypeInferrerImpl<S, E, V, F> extends TypeInferrer<S, E, V, F> {
DartType promotedType = typePromoter.computePromotedType(
typePromotionFact, typePromotionScope, mutatedInClosure);
instrumentation?.record(
- 'promotedType',
Uri.parse(uri),
offset,
+ 'promotedType',
promotedType != null
? new InstrumentationValueForType(promotedType)
: const InstrumentationValueLiteral('none'));
« no previous file with comments | « pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698