pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart - Issue 2839003002: Reorder parameters in Instrumentation.record().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

Issue 2839003002: Reorder parameters in Instrumentation.record(). (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart ('k') | pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

index 91196c868d543ef130858c1038324495e4543140..396d8244962e350212a1a8d2a6053797567e4a13 100644

--- a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

@@ -140,9 +140,9 @@ abstract class TypeInferenceEngineImpl<F> extends TypeInferenceEngine<F> {

typeInferrer.inferFieldInitializer(field, type, type == null);

if (type == null && strongMode) {

instrumentation?.record(

- 'topType',

Uri.parse(typeInferrer.uri),

getFieldOffset(field),

+ 'topType',

new InstrumentationValueForType(inferredType));

setFieldInferredType(field, inferredType);

}

@@ -161,7 +161,7 @@ abstract class TypeInferenceEngineImpl<F> extends TypeInferenceEngine<F> {

// TODO(paulberry): report the appropriate error.

if (getFieldDeclaredType(field) == null) {

var uri = getFieldTypeInferrer(field).uri;

- instrumentation?.record('topType', Uri.parse(uri), getFieldOffset(field),

+ instrumentation?.record(Uri.parse(uri), getFieldOffset(field), 'topType',

const InstrumentationValueLiteral('circular'));

setFieldInferredType(field, const DynamicType());

}