pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart - Issue 2839003002: Reorder parameters in Instrumentation.record().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart

Issue 2839003002: Reorder parameters in Instrumentation.record(). (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/base/instrumentation.dart ('k') | pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart

diff --git a/pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart b/pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart

index 2cc8d54e9e50991ec2c84213ed1b57a22568f6a7..4d2d759bdad306461e777d351f19df5f7700d5c8 100644

--- a/pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart

+++ b/pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart

@@ -141,7 +141,7 @@ class ValidatingInstrumentation implements Instrumentation {

@override

void record(

- String property, Uri uri, int offset, InstrumentationValue value) {

+ Uri uri, int offset, String property, InstrumentationValue value) {

var expectationsForUri = _unsatisfiedExpectations[uri];

if (expectationsForUri == null) return;

var expectationsAtOffset = expectationsForUri[offset];