Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2838993002: Fix XMPP late response. (Closed)

Created:
3 years, 8 months ago by Jamie
Modified:
3 years, 7 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix XMPP late response. BUG= Review-Url: https://codereview.chromium.org/2838993002 Cr-Commit-Position: refs/heads/master@{#468380} Committed: https://chromium.googlesource.com/chromium/src/+/38b76371cb7055257e59dc386e831ecb8c2a6306

Patch Set 1 #

Patch Set 2 : Increase time-out based on analysis. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/webapp/base/js/fallback_signal_strategy.js View 1 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 10 (6 generated)
Jamie
I considered updating this to use whichever strategy succeeded first rather than abandoning XMPP if ...
3 years, 8 months ago (2017-04-26 17:25:40 UTC) #2
garykac
lgtm lgtm (after much discussion ^_^)
3 years, 7 months ago (2017-05-01 18:20:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838993002/20001
3 years, 7 months ago (2017-05-01 18:23:49 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 19:10:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38b76371cb7055257e59dc386e83...

Powered by Google App Engine
This is Rietveld 408576698