Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2838933003: [not-for-commit] kitsune changes + pending kouhei changes (Closed)

Created:
3 years, 8 months ago by kouhei (in TOK)
Modified:
3 years, 7 months ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews-w3ctests_chromium.org, blink-reviews-html_chromium.org, tfarina, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

kitsune changes + pending kouhei changes

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1421 lines, -600 lines) Patch
A dep.js View 1 chunk +3 lines, -0 lines 0 comments Download
A depdep.js View 1 chunk +1 line, -0 lines 0 comments Download
A module.html View 1 chunk +17 lines, -0 lines 0 comments Download
A module.js View 1 chunk +3 lines, -0 lines 0 comments Download
A synerr.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 3 chunks +6 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin-import-different.noinline.sub.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin-import-different.noinline.sub.js View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin-import-missingheader.noinline.sub.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin-import-missingheader.noinline.sub.js View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin-import-same.noinline.sub.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin-import-same.noinline.sub.js View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin-import-wrongheader.noinline.sub.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin-import-wrongheader.noinline.sub.js View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin.noinline.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin.noinline-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/empty.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errored.html View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errored-root.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling-parseerror-common.js View 1 chunk +6 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling-parseerror-dependent.noinline.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling-parseerror-dependent.noinline.js View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling-parseerror-dependentmultiple.noinline.html View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling-parseerror-dependentmultiple.noinline-a.js View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling-parseerror-dependentmultiple.noinline-b.js View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling-parseerror-root.noinline.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling-parseerror-root.noinline.js View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling.noinline.html View 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling.noinline-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/execorder.html View 5 chunks +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/execorder.noinline.html View 6 chunks +12 lines, -16 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/execorder.noinline-a.js View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/imports.noinline.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/imports.noinline-a.js View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/imports.noinline-b.js View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/imports.noinline-c.js View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/imports.noinline-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/test1.html View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/throw.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h View 8 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 chunk +100 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 8 chunks +63 lines, -115 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModulatorImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModulatorImpl.cpp View 2 chunks +45 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModuleMap.cpp View 2 chunks +2 lines, -2 lines 2 comments Download
A third_party/WebKit/Source/core/dom/ModulePendingScript.h View 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ModulePendingScript.cpp View 1 chunk +82 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModuleScript.h View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModuleScript.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 4 chunks +33 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 3 chunks +9 lines, -205 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 5 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 18 chunks +198 lines, -86 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp View 1 chunk +9 lines, -8 lines 1 comment Download
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp View 9 chunks +56 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 10 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp View 5 chunks +39 lines, -21 lines 2 comments Download
M third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp View 9 chunks +54 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
A threejs-bootstrap.html View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kouhei (in TOK)
not for review, but incase if you got stuck... I plan to upload these changes ...
3 years, 8 months ago (2017-04-26 13:00:07 UTC) #2
kouhei (in TOK)
I've only changed places w/ comments so no need to read entire cl https://codereview.chromium.org/2838933003/diff/1/third_party/WebKit/Source/core/dom/ModuleMap.cpp File ...
3 years, 8 months ago (2017-04-26 13:03:44 UTC) #3
hiroshige
https://codereview.chromium.org/2838933003/diff/1/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp File third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp (right): https://codereview.chromium.org/2838933003/diff/1/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp#newcode254 third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp:254: if (urls.IsEmpty()) { On 2017/04/26 13:03:44, kouhei wrote: > ...
3 years, 7 months ago (2017-04-28 01:15:35 UTC) #4
kouhei (in TOK)
3 years, 7 months ago (2017-05-15 20:15:24 UTC) #5 
The changes in this CL already went in.

Powered by Google App Engine
This is Rietveld 408576698