MD Settings: fix policy control detection on default browser section

MD Settings: fix policy control detection on default browser section

All settings/ code was migrated from the older options/ directory. In
this case, the old options default browser code used BooleanPrefMember,
which is a typed wrapper around a PrefService.  The code retrieved the
effective value of the preference (whether it's true or false, for a
bool) via BooleanPrefMember::GetValue().

The new code used a PrefService::Preference instead of a
BooleanPrefMember, and this also has a GetValue() method that returns a
base::Value* (NOT a boolean).  New code checked Preference::GetValue()
as an effective boolean value.  This is effectively dead code (it will
always succeed assuming the preference is registered correctly) and it
did not successfully detect when the preference was false (meaning, when
a policy was set to disable Chrome from setting the default browser).

This patch updates the new code to actually check the bool within the
base::Value* (rather than null check it in a way that always succeeds).

R=tommycli@chromium.org
BUG=711061
Review-Url: https://codereview.chromium.org/2838933002
Cr-Commit-Position: refs/heads/master@{#467133}
Committed: https://chromium.googlesource.com/chromium/src/+/21f439f4fe7a4589c9a0405bc6a385d34a1f3394

[Dan Beam, 2017-04-25 18:54:17]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2017-04-25 18:55:50]

i think we should handle testing separately, this most certainly deserves merge
consideration

[tommycli, 2017-04-25 20:01:46]

lgtm

[Dan Beam, 2017-04-25 20:26:12]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:27:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:14:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493151972902430,
"parent_rev": "45c1839662be78d913edb5c87bfaf9abc66bd9e5", "commit_rev":
"21f439f4fe7a4589c9a0405bc6a385d34a1f3394"}

[commit-bot: I haz the power, 2017-04-25 22:14:24]

Description was changed from

==========
MD Settings: fix policy control detection on default browser section

All settings/ code was migrated from the older options/ directory. In
this case, the old options default browser code used BooleanPrefMember,
which is a typed wrapper around a PrefService.  The code retrieved the
effective value of the preference (whether it's true or false, for a
bool) via BooleanPrefMember::GetValue().

The new code used a PrefService::Preference instead of a
BooleanPrefMember, and this also has a GetValue() method that returns a
base::Value* (NOT a boolean).  New code checked Preference::GetValue()
as an effective boolean value.  This is effectively dead code (it will
always succeed assuming the preference is registered correctly) and it
did not successfully detect when the preference was false (meaning, when
a policy was set to disable Chrome from setting the default browser).

This patch updates the new code to actually check the bool within the
base::Value* (rather than null check it in a way that always succeeds).

R=tommycli@chromium.org
BUG=711061
==========

to

==========
MD Settings: fix policy control detection on default browser section

All settings/ code was migrated from the older options/ directory. In
this case, the old options default browser code used BooleanPrefMember,
which is a typed wrapper around a PrefService.  The code retrieved the
effective value of the preference (whether it's true or false, for a
bool) via BooleanPrefMember::GetValue().

The new code used a PrefService::Preference instead of a
BooleanPrefMember, and this also has a GetValue() method that returns a
base::Value* (NOT a boolean).  New code checked Preference::GetValue()
as an effective boolean value.  This is effectively dead code (it will
always succeed assuming the preference is registered correctly) and it
did not successfully detect when the preference was false (meaning, when
a policy was set to disable Chrome from setting the default browser).

This patch updates the new code to actually check the bool within the
base::Value* (rather than null check it in a way that always succeeds).

R=tommycli@chromium.org
BUG=711061

Review-Url: https://codereview.chromium.org/2838933002
Cr-Commit-Position: refs/heads/master@{#467133}
Committed:
https://chromium.googlesource.com/chromium/src/+/21f439f4fe7a4589c9a0405bc6a3...
==========

[commit-bot: I haz the power, 2017-04-25 22:14:25]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/21f439f4fe7a4589c9a0405bc6a3...