logPrivate API: prevent log dump from trying to use a non-native path

logPrivate API: prevent log dump from trying to use a non-native path

The log dump directory is supposed to be under Downloads, but for a
logged-in user the download path is a non-native path:

    /special/drive-<uid>/...

The logging code uses regular file system calls from base that fail
when encountering "/special".

There is a similar code path in
NetInternalsMessageHandler::OnStoreDebugLogs (net_internals_ui.cc)
which checks for a non-native download path and changes the path to
GetDefaultDownloadDirectoryForProfile; copying that logic to
GetLogDumpDirectory fixes the problem.

API reference: https://developer.chrome.com/extensions/logPrivate

BUG=None
TEST=Build with chromeos=1. Whitelist an extension to allow using the logPrivate API and have the extension call chrome.logPrivate.dumpLogs. Run the extension while logged in (not ephemeral user) and confirm that logs are dumped to Downloads/log_dumps.

Review-Url: https://codereview.chromium.org/2838923004
Cr-Commit-Position: refs/heads/master@{#467326}
Committed: https://chromium.googlesource.com/chromium/src/+/02ebdb393ac0b4c2651881ce8b6a08312c653474

[nicholasbishop, 2017-04-26 00:55:14]

nbishop@neverware.com changed reviewers:
+ finnur@chromium.org

[Finnur, 2017-04-26 13:50:52]

LGTM

[nicholasbishop, 2017-04-26 14:28:50]

The CQ bit was checked by nbishop@neverware.com

[commit-bot: I haz the power, 2017-04-26 14:29:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 14:56:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493216930179550, "parent_rev":
"d86073fac8a47abe754598992e1b8424d7534b9f", "commit_rev":
"02ebdb393ac0b4c2651881ce8b6a08312c653474"}

[commit-bot: I haz the power, 2017-04-26 14:56:56]

Description was changed from

==========
logPrivate API: prevent log dump from trying to use a non-native path

The log dump directory is supposed to be under Downloads, but for a
logged-in user the download path is a non-native path:

    /special/drive-<uid>/...

The logging code uses regular file system calls from base that fail
when encountering "/special".

There is a similar code path in
NetInternalsMessageHandler::OnStoreDebugLogs (net_internals_ui.cc)
which checks for a non-native download path and changes the path to
GetDefaultDownloadDirectoryForProfile; copying that logic to
GetLogDumpDirectory fixes the problem.

API reference: https://developer.chrome.com/extensions/logPrivate

BUG=None
TEST=Build with chromeos=1. Whitelist an extension to allow using the logPrivate
API and have the extension call chrome.logPrivate.dumpLogs. Run the extension
while logged in (not ephemeral user) and confirm that logs are dumped to
Downloads/log_dumps.
==========

to

==========
logPrivate API: prevent log dump from trying to use a non-native path

The log dump directory is supposed to be under Downloads, but for a
logged-in user the download path is a non-native path:

    /special/drive-<uid>/...

The logging code uses regular file system calls from base that fail
when encountering "/special".

There is a similar code path in
NetInternalsMessageHandler::OnStoreDebugLogs (net_internals_ui.cc)
which checks for a non-native download path and changes the path to
GetDefaultDownloadDirectoryForProfile; copying that logic to
GetLogDumpDirectory fixes the problem.

API reference: https://developer.chrome.com/extensions/logPrivate

BUG=None
TEST=Build with chromeos=1. Whitelist an extension to allow using the logPrivate
API and have the extension call chrome.logPrivate.dumpLogs. Run the extension
while logged in (not ephemeral user) and confirm that logs are dumped to
Downloads/log_dumps.

Review-Url: https://codereview.chromium.org/2838923004
Cr-Commit-Position: refs/heads/master@{#467326}
Committed:
https://chromium.googlesource.com/chromium/src/+/02ebdb393ac0b4c2651881ce8b6a...
==========

[commit-bot: I haz the power, 2017-04-26 14:56:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02ebdb393ac0b4c2651881ce8b6a...