Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Unified Diff: base/trace_event/memory_tracing_observer.cc

Issue 2838913002: memory-infra: Add SUMMARY_ONLY MemoryDumpType (Closed)
Patch Set: return true if summary only not added to trace Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_tracing_observer.cc
diff --git a/base/trace_event/memory_tracing_observer.cc b/base/trace_event/memory_tracing_observer.cc
index 3130b205f89c25f70f30c8dd11e0c02558dd3a1c..97581d0c4ca2e88f4e46e36f82ae4dfde59eb205 100644
--- a/base/trace_event/memory_tracing_observer.cc
+++ b/base/trace_event/memory_tracing_observer.cc
@@ -72,6 +72,8 @@ bool MemoryTracingObserver::AddDumpToTraceIfEnabled(
if (!IsMemoryInfraTracingEnabled())
return false;
+ CHECK(req_args->dump_type != MemoryDumpType::SUMMARY_ONLY);
Primiano Tucci (use gerrit) 2017/04/25 18:02:22 CHECK_NE(MemoryDumpType::SUMMARY_ONLY, req_args->d
hjd 2017/04/26 11:11:58 Done.
+
const uint64_t dump_guid = req_args->dump_guid;
std::unique_ptr<TracedValue> traced_value(new TracedValue);

Powered by Google App Engine
This is Rietveld 408576698