Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/trace_event/memory_dump_request_args.h

Issue 2838913002: memory-infra: Add SUMMARY_ONLY MemoryDumpType (Closed)
Patch Set: return true if summary only not added to trace Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/trace_event/memory_dump_manager_unittest.cc ('K') | « base/trace_event/memory_dump_manager_unittest.cc ('k') | base/trace_event/memory_dump_request_args.cc » ('j') | base/trace_event/memory_tracing_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_request_args.h
diff --git a/base/trace_event/memory_dump_request_args.h b/base/trace_event/memory_dump_request_args.h
index 0f42a185310bf10ff68803f1aba29dc3dc44be2f..b083efbe3b3656da21aeffd51cc55c628840c5d0 100644
--- a/base/trace_event/memory_dump_request_args.h
+++ b/base/trace_event/memory_dump_request_args.h
@@ -28,7 +28,8 @@ enum class MemoryDumpType {
PERIODIC_INTERVAL, // Dumping memory at periodic intervals.
EXPLICITLY_TRIGGERED, // Non maskable dump request.
PEAK_MEMORY_USAGE, // Dumping memory at detected peak total memory usage.
- LAST = PEAK_MEMORY_USAGE // For IPC macros.
+ SUMMARY_ONLY, // Calculate just the summary & don't add to the trace.
+ LAST = SUMMARY_ONLY // For IPC macros.
ssid 2017/04/25 18:09:51 Nit: can you remove the comment that says IPC macr
hjd 2017/04/26 11:11:58 Done.
};
// Tells the MemoryDumpProvider(s) how much detailed their dumps should be.
« base/trace_event/memory_dump_manager_unittest.cc ('K') | « base/trace_event/memory_dump_manager_unittest.cc ('k') | base/trace_event/memory_dump_request_args.cc » ('j') | base/trace_event/memory_tracing_observer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698