Remove base::ListValue::Set(size_t, base::Value*)

ipc/ipc_message_utils.cc

Index: ipc/ipc_message_utils.cc
diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc
index 23cfd1339b5cd2d382a371fa4a29eafdf1bb2f17..a727cff155e12d4be5e32b148e47f2c487cf9372 100644
--- a/ipc/ipc_message_utils.cc
+++ b/ipc/ipc_message_utils.cc
@@ -9,6 +9,7 @@
 
 #include "base/files/file_path.h"
 #include "base/json/json_writer.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/nullable_string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ -241,7 +242,7 @@ bool ReadListValue(const base::Pickle* m,
     base::Value* subval;
     if (!ReadValue(m, iter, &subval, recursion + 1))

[vabr (Chromium), 2017/04/25 17:13:15]

I suggest fixing ReadValue to take a pointer to unique_ptr<base::Value> instead.
It only has two callsites. By doing that you can also fix the
SetWithoutPathExpansion at the other callsite.

[jdoerrie, 2017/04/26 11:34:37]

Done.

       return false;
-    value->Set(i, subval);
+    value->Set(i, base::WrapUnique(subval));
   }
 
   return true;