components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Fix Compilation Error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc

index e9a5338c84caf64d4a4a6af129491d9dc9d19207..da671d3427219e53a51f8ae239274d81cc57e1cd 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc

@@ -163,13 +163,12 @@ class DataReductionProxyCompressionStatsTest : public testing::Test {

for (size_t i = 0; i < kNumDaysInHistory; ++i) {

original_daily_content_length_list->Set(

- i, new base::Value(base::SizeTToString(i)));

+ i, base::MakeUnique<base::Value>(base::SizeTToString(i)));

}

received_daily_content_length_list->Clear();

for (size_t i = 0; i < kNumDaysInHistory / 2; ++i) {

- received_daily_content_length_list->Set(

- i, new base::Value(base::SizeTToString(i)));

+ received_daily_content_length_list->AppendString(base::SizeTToString(i));

}